Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: src/ic/ic.cc

Issue 1102923002: [strong] Disallow implicit conversions for bitwise ops, shifts (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback 2 Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/runtime.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index 6ecc0771ec83146d0d623e6058dcf0fd16f8ec0e..1f94c47429ac9bfba223e1c599026232f45f23df 100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -2821,12 +2821,12 @@ Builtins::JavaScript BinaryOpIC::TokenToJSBuiltin(Token::Value op,
case Token::MUL: return Builtins::MUL_STRONG;
case Token::DIV: return Builtins::DIV_STRONG;
case Token::MOD: return Builtins::MOD_STRONG;
- case Token::BIT_OR: return Builtins::BIT_OR;
- case Token::BIT_AND: return Builtins::BIT_AND;
- case Token::BIT_XOR: return Builtins::BIT_XOR;
- case Token::SAR: return Builtins::SAR;
- case Token::SHR: return Builtins::SHR;
- case Token::SHL: return Builtins::SHL;
+ case Token::BIT_OR: return Builtins::BIT_OR_STRONG;
+ case Token::BIT_AND: return Builtins::BIT_AND_STRONG;
+ case Token::BIT_XOR: return Builtins::BIT_XOR_STRONG;
+ case Token::SAR: return Builtins::SAR_STRONG;
+ case Token::SHR: return Builtins::SHR_STRONG;
+ case Token::SHL: return Builtins::SHL_STRONG;
}
} else {
switch (op) {
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/runtime.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698