src/builtins.h - Issue 1102923002: [strong] Disallow implicit conversions for bitwise ops, shifts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.h

Issue 1102923002: [strong] Disallow implicit conversions for bitwise ops, shifts (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback 2 Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.h

diff --git a/src/builtins.h b/src/builtins.h

index ecf83c54d693de744ccd8b106f0a37cd10b97012..79d6f61c2c0fbb84b13b33042b3f746a51be5977 100644

--- a/src/builtins.h

+++ b/src/builtins.h

@@ -179,11 +179,17 @@ enum BuiltinExtraArguments {

V(MOD, 1) \

V(MOD_STRONG, 1) \

V(BIT_OR, 1) \

+ V(BIT_OR_STRONG, 1) \

V(BIT_AND, 1) \

+ V(BIT_AND_STRONG, 1) \

V(BIT_XOR, 1) \

+ V(BIT_XOR_STRONG, 1) \

V(SHL, 1) \

+ V(SHL_STRONG, 1) \

V(SAR, 1) \

+ V(SAR_STRONG, 1) \

V(SHR, 1) \

+ V(SHR_STRONG, 1) \

V(DELETE, 2) \

V(IN, 1) \

V(INSTANCE_OF, 1) \

« no previous file with comments | « no previous file | src/compiler/js-typed-lowering.cc » ('j') | no next file with comments »