Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4278)

Unified Diff: build/common.gypi

Issue 11029061: Add Android version name and code to gyp settings. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 960c36b13138553ff7389ce7ec7ab0f5085a3635..2d6ce238066bbe93497a9e6d1919a5d3c4c574ba 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -99,6 +99,11 @@
# Android build system, value 1).
'android_build_type%': 0,
+ # Sets the default version name and code for Android app, by default we
+ # do a developer build.
+ 'android_app_version_name%': 'Developer Build',
+ 'android_app_version_code%': 0,
+
# Compute the architecture that we're building on.
'conditions': [
['OS=="win" or OS=="mac" or OS=="ios"', {
@@ -151,6 +156,8 @@
'enable_touch_ui%': '<(enable_touch_ui)',
'android_upstream_bringup%': '<(android_upstream_bringup)',
'android_build_type%': '<(android_build_type)',
+ 'android_app_version_name%': '<(android_app_version_name)',
+ 'android_app_version_code%': '<(android_app_version_code)',
# We used to provide a variable for changing how libraries were built.
# This variable remains until we can clean up all the users.
@@ -669,6 +676,8 @@
'use_libjpeg_turbo%': '<(use_libjpeg_turbo)',
'use_system_libjpeg%': '<(use_system_libjpeg)',
'android_build_type%': '<(android_build_type)',
+ 'android_app_version_name%': '<(android_app_version_name)',
cjhopman 2012/10/05 20:16:20 Can't you just set the defaults here rather than s
shashi 2012/10/05 20:42:49 Done, the reason I did it was mostly for conventio
+ 'android_app_version_code%': '<(android_app_version_code)',
'use_official_google_api_keys%': '<(use_official_google_api_keys)',
'google_api_key%': '<(google_api_key)',
'google_default_client_id%': '<(google_default_client_id)',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698