Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1102903002: [strong] Simplify the classes-referring-to-classes check. (Closed)

Created:
5 years, 8 months ago by marja
Modified:
5 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Simplify the classes-referring-to-classes check. Follow up for r28032. We don't need to store the "corresponding outer scope class variables", it's enough if we transmit the declaration group start to the inner class variable. R=rossberg@chromium.org BUG=v8:3956 LOG=N Committed: https://crrev.com/21557b4899255540b1bd81a732521607f1c22162 Cr-Commit-Position: refs/heads/master@{#28048}

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -52 lines) Patch
M src/parser.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/scopes.cc View 1 1 chunk +33 lines, -41 lines 0 comments Download
M src/variables.h View 1 2 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
marja
rossberg, here's another potential simplification, wdyt? (This way, we wouldn't need to store the "corresponding ...
5 years, 8 months ago (2015-04-24 12:40:00 UTC) #1
rossberg
Great idea, LGTM!
5 years, 8 months ago (2015-04-24 13:02:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102903002/20001
5 years, 8 months ago (2015-04-24 13:03:35 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 13:05:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 13:05:30 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21557b4899255540b1bd81a732521607f1c22162
Cr-Commit-Position: refs/heads/master@{#28048}

Powered by Google App Engine
This is Rietveld 408576698