Issue 1102863002: Revert of Fetch OAuth2 tokens prior to profile creation.

Issue 1102863002: Revert of Fetch OAuth2 tokens prior to profile creation. (Closed)

Created:
5 years, 8 months ago by horo

Modified:
5 years, 8 months ago

Reviewers:
xiyuan, achuithb, Nikita (slow)

CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fetch OAuth2 tokens prior to profile creation. (patchset #7 id:140001 of https://codereview.chromium.org/1097663003/) Reason for revert: Caused browser_tests failure. https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1403/steps/browser_tests Original issue's description: > Fetch OAuth2 tokens prior to profile creation. > > BUG=470984 > TEST= > > Committed: https://crrev.com/163a4a63af5e56801395eed067a69e501e7b51a5 > Cr-Commit-Position: refs/heads/master@{#326691} TBR=xiyuan@chromium.org,nkostylev@chromium.org,achuith@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470984 Committed: https://crrev.com/4f49c2c56dad1ce2a2ca2a7df3610814ccc6d80b Cr-Commit-Position: refs/heads/master@{#326713}

Created: 5 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -172 lines)			Patch
M	chrome/browser/chromeos/login/existing_user_controller.h	View	3 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	4 chunks	+1 line, -22 lines	0 comments	Download
M	chrome/browser/chromeos/login/saml/saml_browsertest.cc	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/session/user_session_manager.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/signin/oauth2_login_manager.h	View	4 chunks	+20 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/login/signin/oauth2_login_manager.cc	View	2 chunks	+25 lines, -18 lines	0 comments	Download
D	chrome/browser/chromeos/login/signin/oauth2_token_initializer.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	chrome/browser/chromeos/login/signin/oauth2_token_initializer.cc	View	1 chunk	+0 lines, -41 lines	0 comments	Download
M	chrome/chrome_browser_chromeos.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chromeos/login/auth/user_context.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	chromeos/login/auth/user_context.cc	View	4 chunks	+6 lines, -14 lines	0 comments	Download

Total messages: 4 (0 generated)

horo

Created Revert of Fetch OAuth2 tokens prior to profile creation.

5 years, 8 months ago (2015-04-24 01:20:29 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102863002/1

5 years, 8 months ago (2015-04-24 01:20:53 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 01:23:00 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4f49c2c56dad1ce2a2ca2a7df3610814ccc6d80b
Cr-Commit-Position: refs/heads/master@{#326713}