Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1102833003: [iOS] Upstream UpdatableConfig test provider (Closed)

Created:
5 years, 8 months ago by sdefresne
Modified:
5 years, 8 months ago
Reviewers:
droger
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream UpdatableConfig test provider BUG=429756 R=droger Committed: https://crrev.com/34ffe6a14d04517f955053850046dbe4dcffebee Cr-Commit-Position: refs/heads/master@{#326904}

Patch Set 1 #

Patch Set 2 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -0 lines) Patch
M ios/ios_tests.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A ios/public/test/test_updatable_resource_provider.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/public/test/test_updatable_resource_provider.mm View 1 chunk +102 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sdefresne
5 years, 8 months ago (2015-04-24 15:52:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102833003/1
5 years, 8 months ago (2015-04-24 15:52:59 UTC) #3
droger
lgtm
5 years, 8 months ago (2015-04-24 15:53:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102833003/20001
5 years, 8 months ago (2015-04-24 16:01:15 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-24 16:23:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102833003/20001
5 years, 8 months ago (2015-04-24 22:23:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-24 22:24:41 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 22:25:51 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/34ffe6a14d04517f955053850046dbe4dcffebee
Cr-Commit-Position: refs/heads/master@{#326904}

Powered by Google App Engine
This is Rietveld 408576698