Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1102833002: Reland: AppControllerMac updates the window when a Profile is deleted. (Closed)

Created:
5 years, 8 months ago by Mike Lerman
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, rginda+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: AppControllerMac updates the window when a Profile is deleted. This issue landed here: https://codereview.chromium.org/1097553002/ And was reverted here: https://codereview.chromium.org/1072193012/ Because it failed flaky, due to second profile's history service not being initialized. This CL relands the original, with a modification line 474 of app_controller_mac_browsertest.mm to call WaitForHistoryToLoad. BUG=477392 Committed: https://crrev.com/8ae56aa8bd8bb731975d48957c3227799b9a194f Cr-Commit-Position: refs/heads/master@{#326787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3 lines) Patch
M chrome/browser/app_controller_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/app_controller_mac.mm View 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 3 chunks +74 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mike Lerman
Hi Robert, My CL was reverted because it failed flaky. I was able to repro ...
5 years, 8 months ago (2015-04-23 22:01:31 UTC) #2
Robert Sesek
LGTM
5 years, 8 months ago (2015-04-23 22:04:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102833002/1
5 years, 8 months ago (2015-04-24 12:08:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 13:56:38 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 13:57:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ae56aa8bd8bb731975d48957c3227799b9a194f
Cr-Commit-Position: refs/heads/master@{#326787}

Powered by Google App Engine
This is Rietveld 408576698