Re-factor Ash Message Center code part 2/4

Moves TrayBubbleView out of ash namespace
Creates TrayEventFilter and TrayBubbleWrapper.

BUG=150872
For ash.gyp:
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161888

[stevenjb, 2012-10-11 17:15:15]

This is the next step in re-factoring the web notification code so that we can
move the message center bubbles into ui/views. It eliminates ash dependencies
from TrayBubbleView.

When I move the files to ui/views I'll rename them and change the namespaces.

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tray.cc
File ash/system/tray/system_tray.cc (left):

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray.cc:273: void
SystemTray::RemoveBubble(SystemTrayBubble* bubble) {
Renamed HideBubble and moved below

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tray...
File ash/system/tray/system_tray_bubble.h (left):

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tray...
ash/system/tray/system_tray_bubble.h:73: views::Widget* bubble_widget_;
Widget is now maintained by TrayBubbleWrapper

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_backgr...
File ash/system/tray/tray_background_view.cc (right):

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_backgr...
ash/system/tray/tray_background_view.cc:284: 
Functionality moved from TrayBubbleView

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_bubble...
File ash/system/tray/tray_bubble_view.h (right):

http://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_bubble...
ash/system/tray/tray_bubble_view.h:80: InitParams* init_params);
Moved init_params to the end and made them a pointer so that they can be
modified without having to copy them.

[miket_OOO, 2012-10-12 19:53:59]

LGTM, and thanks for doing this. None of my comments are substantive.

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tra...
File ash/system/tray/system_tray.cc (right):

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tra...
ash/system/tray/system_tray.cc:443: void SystemTray::HideBubble(TrayBubbleView*
bubble_view) {
It's weird that this parameter could be const, but that appears to be the case.
That said, I don't think it should be.

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_bubbl...
File ash/system/tray/tray_bubble_view.cc (right):

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_bubbl...
ash/system/tray/tray_bubble_view.cc:314: params_.anchor_alignment);
Nice.

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_bubbl...
File ash/system/tray/tray_bubble_view.h (left):

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/tray_bubbl...
ash/system/tray/tray_bubble_view.h:22: namespace internal {
Cool!

https://codereview.chromium.org/11028134/diff/3001/ash/system/web_notificatio...
File ash/system/web_notification/popup_bubble.cc (left):

https://codereview.chromium.org/11028134/diff/3001/ash/system/web_notificatio...
ash/system/web_notification/popup_bubble.cc:18: using internal::TrayBubbleView;
Great!

[stevenjb, 2012-10-12 20:39:28]

jennyz@ - I am going to wait for you to review this also since it's kind of
hairy, thanks.

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tra...
File ash/system/tray/system_tray.cc (right):

https://codereview.chromium.org/11028134/diff/3001/ash/system/tray/system_tra...
ash/system/tray/system_tray.cc:443: void SystemTray::HideBubble(TrayBubbleView*
bubble_view) {
On 2012/10/12 19:53:59, miket wrote:
> It's weird that this parameter could be const, but that appears to be the
case.
> That said, I don't think it should be.
Actually, you're right, it is weird, and I think I will change the function to
HideBubbleWithView() and make bubble_view const.

[miket_OOO, 2012-10-12 21:11:38]

> Actually, you're right, it is weird, and I think I will change the function to
> HideBubbleWithView() and make bubble_view const.

That makes sense. Thanks!

[jennyz, 2012-10-12 23:05:34]

ltgm with nits.

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_back...
File ash/system/tray/tray_background_view.h (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_back...
ash/system/tray/tray_background_view.h:90: // is closed.
Hide -> Hides

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_back...
ash/system/tray/tray_background_view.h:109: // Initialize animations for the
bubble.
Initialize->Initializes

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
File ash/system/tray/tray_bubble_view.cc (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_view.cc:285: void
TrayBubbleView::InitializeAndShowBubble(views::Widget* widget) {
The input argument widget is not used, remove it?

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
File ash/system/tray/tray_bubble_view.h (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_view.h:87: // is called.
Set->Sets

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_view.h:96: // Return the border insets. Called by
TrayEventFilter.
Return->Returns

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
File ash/system/tray/tray_bubble_wrapper.h (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_wrapper.h:21: // Creates and manages thes withe
Widget and EventFilter components of a bubble.
"thes withe"->"the"?

[jennyz, 2012-10-12 23:06:34]

lgtm with nits.

[stevenjb, 2012-10-12 23:41:50]

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_back...
File ash/system/tray/tray_background_view.h (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_back...
ash/system/tray/tray_background_view.h:90: // is closed.
On 2012/10/12 23:05:34, jennyz wrote:
> Hide -> Hides

Done.

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_back...
ash/system/tray/tray_background_view.h:109: // Initialize animations for the
bubble.
On 2012/10/12 23:05:34, jennyz wrote:
> Initialize->Initializes

Done.

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
File ash/system/tray/tray_bubble_view.cc (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_view.cc:285: void
TrayBubbleView::InitializeAndShowBubble(views::Widget* widget) {
On 2012/10/12 23:05:34, jennyz wrote:
> The input argument widget is not used, remove it?

Done.

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
File ash/system/tray/tray_bubble_view.h (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_view.h:87: // is called.
On 2012/10/12 23:05:34, jennyz wrote:
> Set->Sets

Done.

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_view.h:96: // Return the border insets. Called by
TrayEventFilter.
On 2012/10/12 23:05:34, jennyz wrote:
> Return->Returns

Done.

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
File ash/system/tray/tray_bubble_wrapper.h (right):

https://codereview.chromium.org/11028134/diff/17024/ash/system/tray/tray_bubb...
ash/system/tray/tray_bubble_wrapper.h:21: // Creates and manages thes withe
Widget and EventFilter components of a bubble.
On 2012/10/12 23:05:34, jennyz wrote:
> "thes withe"->"the"?

Done.