cc: Improve texture per second calculation and overhead

cc/ThrottledTextureUploader.cpp

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "ThrottledTextureUploader.h"
 
 #include "Extensions3DChromium.h"
 #include "TraceEvent.h"
 #include <algorithm>
+#include <iterator>
 #include <public/Platform.h>
 #include <public/WebGraphicsContext3D.h>
-#include <vector>
 
 namespace {
 
 // How many previous uploads to use when predicting future throughput.
-static const size_t uploadHistorySize = 100;
+static const size_t uploadHistorySizeMax = 1000;
+static const size_t uploadHistorySizeInitial = 100;
 
 // Global estimated number of textures per second to maintain estimates across
 // subsequent instances of ThrottledTextureUploader.
 // More than one thread will not access this variable, so we do not need to synchronize access.
 static double estimatedTexturesPerSecondGlobal = 48.0 * 60.0;
 
 } // anonymous namespace
 
 namespace cc {
 
@@ skipping 51 matching lines @@
     m_isNonBlocking = true;
 }
 
 bool ThrottledTextureUploader::Query::isNonBlocking()
 {
     return m_isNonBlocking;
 }
 
 ThrottledTextureUploader::ThrottledTextureUploader(WebKit::WebGraphicsContext3D* context)
     : m_context(context)
-    , m_texturesPerSecondHistory(uploadHistorySize, estimatedTexturesPerSecondGlobal)
     , m_numBlockingTextureUploads(0)
+    , m_historyRemovalCount(0)
 {
+    for (size_t i = uploadHistorySizeInitial; i > 0; i--)
+        m_texturesPerSecondHistory.insert(estimatedTexturesPerSecondGlobal);
 }
 
 ThrottledTextureUploader::~ThrottledTextureUploader()
 {
 }
 
 size_t ThrottledTextureUploader::numBlockingUploads()
 {
     processQueries();
     return m_numBlockingTextureUploads;
@@ skipping 10 matching lines @@
         it->get()->markAsNonBlocking();
     }
 
     ASSERT(!m_numBlockingTextureUploads);
 }
 
 double ThrottledTextureUploader::estimatedTexturesPerSecond()
 {
     processQueries();
 
-    // The history should never be empty because we initialize all elements with an estimate.
-    ASSERT(m_texturesPerSecondHistory.size() == uploadHistorySize);
-
-    // Sort the history and use the median as our estimate.
-    std::vector<double> sortedHistory(m_texturesPerSecondHistory.begin(),
-                                      m_texturesPerSecondHistory.end());
-    std::sort(sortedHistory.begin(), sortedHistory.end());
-
-    estimatedTexturesPerSecondGlobal = sortedHistory[sortedHistory.size() * 2 / 3];
+    // Use the 3/4 median as our optimistic estimate.

[reveman, 2012/10/12 01:41:00]

I'm not convinced that 3/4 median magic number we should use here. Can we tune
these details separately? Preferably after we land your 'fill upload queue
patch'.

+    std::set<double>::iterator median = m_texturesPerSecondHistory.end();
+    std::advance(median, -(int)m_texturesPerSecondHistory.size() / 4);

[reveman, 2012/10/12 01:41:00]

nit: use static_cast<> here

+    estimatedTexturesPerSecondGlobal = *median;
     TRACE_COUNTER1("cc", "estimatedTexturesPerSecond", estimatedTexturesPerSecondGlobal);
     return estimatedTexturesPerSecondGlobal;
 }
 
 void ThrottledTextureUploader::beginQuery()
 {
     processQueries();
 
     if (m_availableQueries.isEmpty())
       m_availableQueries.append(Query::create(m_context));
@@ skipping 27 matching lines @@
     while (!m_pendingQueries.isEmpty()) {
         if (m_pendingQueries.first()->isPending())
             break;
 
         unsigned usElapsed = m_pendingQueries.first()->value();
         WebKit::Platform::current()->histogramCustomCounts("Renderer4.TextureGpuUploadTimeUS", usElapsed, 0, 100000, 50);
 
         if (!m_pendingQueries.first()->isNonBlocking())
             m_numBlockingTextureUploads--;
 
-        // Remove the oldest values from our history and insert the new one
+        // Alternately remove the min or max value from our history and insert the new one.
+        // We remove the min 3/4 of the time and the max 1/4 of the time to keep an optimistic history.
         double texturesPerSecond = 1.0 / (usElapsed * 1e-6);
-        m_texturesPerSecondHistory.pop_back();
-        m_texturesPerSecondHistory.push_front(texturesPerSecond);
+        m_texturesPerSecondHistory.insert(texturesPerSecond);

[reveman, 2012/10/12 01:41:00]

maybe do the remove before adding the new value?

+        if (m_texturesPerSecondHistory.size() >= uploadHistorySizeMax) {
+            if (m_historyRemovalCount & 0x3)

[reveman, 2012/10/12 01:41:00]

how about we save the 3/4 and 1/4 details for later?

lets get rid of m_historyRemovalCount and just do multiple removals here when
size() >= uploadHistorySizeMax.

+                m_texturesPerSecondHistory.erase(m_texturesPerSecondHistory.begin());
+            else
+                m_texturesPerSecondHistory.erase(--m_texturesPerSecondHistory.end());
+            m_historyRemovalCount++;
+        }
 
         m_availableQueries.append(m_pendingQueries.takeFirst());
     }
 }
 
 }