net/data/websocket/websocket_shared_worker.html - Issue 11028111: Replace WorkerWebSocketHttpLayoutTest with WorkerTest.WebSocketSharedWorker

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/data/websocket/websocket_shared_worker.html

Issue 11028111: Replace WorkerWebSocketHttpLayoutTest with WorkerTest.WebSocketSharedWorker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: retain std::string reference for GURL::Replacements Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/worker_host/test/worker_browsertest.cc ('K') | « content/browser/worker_host/test/worker_browsertest.cc ('k') | net/data/websocket/websocket_worker_simple.js » ('j') | net/data/websocket/websocket_worker_simple.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 <div id=result></div>

	4 <script>

	5 function log(message)

	6 {
	Yuta Kitamura 2012/10/15 07:44:37 nit: I think this brace needs to be placed at the nit: I think this brace needs to be placed at the end of the previous line. Takashi Toyoshima 2012/10/15 08:14:34 This style follows chrome/test/data/workers/.html This style follows chrome/test/data/workers/.html. function definition requires line break before brace, and assign like var foo = function() {...} doesn't as line 18. So, I'd like to keep this style for consistency.
	7 document.getElementById("result").innerHTML += message + "<br>";

	8 }

	9 var worker = new SharedWorker("websocket_worker_simple.js");

	10 var href = window.location.href;

	11 var hostBegin = href.indexOf("/") + 2;

	12 var hostEnd = href.lastIndexOf(":");

	13 var host = href.slice(hostBegin, hostEnd);

	14 var portBegin = hostEnd + 1;

	15 var portEnd = href.lastIndexOf("/");

	16 var port = href.slice(portBegin, portEnd);

	17 var url = "ws://" + host + ":" + port + "/echo";

	18 worker.port.onmessage = function (evt) {

	19 log(evt.data);

	20 if (evt.data == "DONE") {

	21 document.title = "OK";

	22 } else {

	23 document.title = "FAIL";

	24 }

	25 };

	26 worker.port.postMessage(url);

	27

	28 </script>

	29 </body>

	30 </html>

	31

OLD	NEW