Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5620)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 11028080: Merge 159215 - Add extra buckets to CrashExitCodes histogram for sandbox terminations. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1271/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sandbox/win/src/sandbox_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
===================================================================
--- chrome/browser/metrics/metrics_service.cc (revision 160736)
+++ chrome/browser/metrics/metrics_service.cc (working copy)
@@ -215,6 +215,7 @@
#if defined(OS_WIN)
#include <windows.h> // Needed for STATUS_* codes
+#include "sandbox/win/src/sandbox_types.h" // For termination codes.
#endif
using base::Time;
@@ -346,6 +347,12 @@
for (size_t i = 0; i < arraysize(kExceptionCodes); ++i)
codes.push_back(MapCrashExitCodeForHistogram(kExceptionCodes[i]));
+
+ // Add the sandbox fatal termination codes.
+ for (int i = sandbox::SBOX_FATAL_INTEGRITY;
+ i <= sandbox::SBOX_FATAL_LAST; ++i) {
+ codes.push_back(MapCrashExitCodeForHistogram(i));
+ }
#endif
return codes;
« no previous file with comments | « no previous file | sandbox/win/src/sandbox_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698