Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: tests/isolate/timer_cancel1_test.dart

Issue 11028076: Fix timer tests: timer tests were not using expectAsync to wait for (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Mark some tests as flaky in FF Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/isolate/spawn_function_test.dart ('k') | tests/isolate/timer_cancel2_test.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library('timer_cancel1_test'); 5 #library('timer_cancel1_test');
6 6
7 #import("dart:isolate"); 7 #import("dart:isolate");
8 #import('../../pkg/unittest/unittest.dart');
8 9
9 // Test that a timeout handler can cancel another. 10 main() {
10 class TimerCancel1Test { 11 // Test that a timeout handler can cancel another.
11 static void testOtherCancel() { 12 test("timer cancel1 test", () {
12 var canceleeTimer; 13 var canceleeTimer;
13 var cancelerTimer; 14 var cancelerTimer;
14 15
15 void timeoutHandlerUnreachable(Timer timer) { 16 void unreachable(Timer timer) {
16 Expect.fail("A canceled timeout handler should be unreachable."); 17 fail("A canceled timeout handler should be unreachable.");
17 } 18 }
18 19
19 void cancelHandler(Timer timer) { 20 void handler(Timer timer) {
20 canceleeTimer.cancel(); 21 canceleeTimer.cancel();
21 } 22 }
22 23
23 cancelerTimer = new Timer(1, cancelHandler); 24 cancelerTimer = new Timer(1, expectAsync1(handler));
24 canceleeTimer = new Timer(1000, timeoutHandlerUnreachable); 25 canceleeTimer = new Timer(1000, expectAsync1(unreachable, count: 0));
25 } 26 });
26
27 static void testMain() {
28 testOtherCancel();
29 }
30 } 27 }
31
32 main() {
33 TimerCancel1Test.testMain();
34 }
OLDNEW
« no previous file with comments | « tests/isolate/spawn_function_test.dart ('k') | tests/isolate/timer_cancel2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698