Fix timer tests: timer tests were not using expectAsync to wait for

pkg/unittest/unittest.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * A library for writing dart unit tests.
  *
  * To import this library, specify the relative path to
  * pkg/unittest/unittest.dart.
  *
@@ skipping 301 matching lines @@
   int _actualCalls = 0;
   int _testNum;
   TestCase _testCase;
   Function _shouldCallBack;
   Function _isDone;
   static const _sentinel = const _Sentinel();
 
   _init(Function callback, Function shouldCallBack, Function isDone,
        [expectedCalls = 0]) {
     ensureInitialized();
+    if (!(_currentTest >= 0 &&
+           _currentTest < _tests.length &&
+           _tests[_currentTest] != null)) {
+      print("No valid test, did you forget to run your test inside a call "

[Siggi Cherem (dart-lang), 2012/10/08 21:50:07]

I'm surprised you need this... I'm cc'ing Graham for input (he is currently
maintaining this code).

[gram, 2012/10/08 22:03:30]

We have an assert on the next line for the converse of this. As such, having a
print here should be harmless. But I agree, it shouldn't be necessary.

[justinfagnani, 2012/10/08 22:12:48]

I added an expectAsync to a test before wrapping it in test() and it took a
while for me to figure out what was going on. This is for the next person (or
me) who does that.

[justinfagnani, 2012/10/08 22:12:48]

The problem was that I wasn't getting the source of the failure or any useful
message. Should we expect a stacktrace to be printed for failed asserts?

[Siggi Cherem (dart-lang), 2012/10/08 22:29:15]

I see - I hope so. We can also turn the assert into a throw inside this
condition instead. That way it is thrown also if you don't have assertions
enabled in the vm

+          "to test()?");
+    }
     assert(_currentTest >= 0 &&
            _currentTest < _tests.length &&
            _tests[_currentTest] != null);
     _callback = callback;
     _shouldCallBack = shouldCallBack;
     _isDone = isDone;
     _expectedCalls = expectedCalls;
     _testNum = _currentTest;
     _testCase = _tests[_currentTest];
     if (expectedCalls > 0) {
@@ skipping 539 matching lines @@
 }
 
 /** Enable a test by ID. */
 void enableTest(int testId) => _setTestEnabledState(testId, true);
 
 /** Disable a test by ID. */
 void disableTest(int testId) => _setTestEnabledState(testId, false);
 
 /** Signature for a test function. */
 typedef void TestFunction();