Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1102803002: Remove the pending container size requests list (Closed)

Created:
5 years, 8 months ago by davve
Modified:
5 years, 8 months ago
CC:
blink-reviews, Yoav Weiss, Nate Chapin, gavinp+loader_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove the pending container size requests list Trust ImageResource::setContainerSizeForLayoutObject to be called through ImageResource::notifyObservers when the image has loaded. Given that, we will already get notifications about the up-to-date containerSize and containerZoom and there is no need for keeping around a list of pending container sizes and zooms to send when the image is created. As to why we can trust ImageResource::notifyObservers to call back into ImageResource::setContainerSizeForLayoutObject, https://codereview.chromium.org/22482004 added a updateInnerContentRect() call taking care of calling ImageResource::setContainerSizeForLayoutObject when the image's paint has been invalidated. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194439

Patch Set 1 #

Patch Set 2 : Remove now unused typedefs #

Patch Set 3 : Remove now redundant virtual method #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -40 lines) Patch
M Source/core/fetch/ImageResource.h View 1 2 1 chunk +0 lines, -5 lines 2 comments Download
M Source/core/fetch/ImageResource.cpp View 1 2 5 chunks +1 line, -35 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
davve
This is a timing sensitive area, but from three try-bot runs no tests seem to ...
5 years, 8 months ago (2015-04-24 12:47:13 UTC) #2
pdr.
On 2015/04/24 at 12:47:13, davve wrote: > This is a timing sensitive area, but from ...
5 years, 8 months ago (2015-04-25 02:23:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102803002/40001
5 years, 8 months ago (2015-04-25 02:24:21 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194439
5 years, 8 months ago (2015-04-25 16:42:37 UTC) #6
sof
https://codereview.chromium.org/1102803002/diff/40001/Source/core/fetch/ImageResource.h File Source/core/fetch/ImageResource.h (left): https://codereview.chromium.org/1102803002/diff/40001/Source/core/fetch/ImageResource.h#oldcode132 Source/core/fetch/ImageResource.h:132: virtual void switchClientsToRevalidatedResource() override; If the CL sticks, this ...
5 years, 8 months ago (2015-04-25 18:44:13 UTC) #7
davve
5 years, 8 months ago (2015-04-25 20:53:24 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/1102803002/diff/40001/Source/core/fetch/Image...
File Source/core/fetch/ImageResource.h (left):

https://codereview.chromium.org/1102803002/diff/40001/Source/core/fetch/Image...
Source/core/fetch/ImageResource.h:132: virtual void
switchClientsToRevalidatedResource() override;
On 2015/04/25 18:44:13, sof wrote:
> If the CL sticks, this method can now be de-virtual'ized (and made private)
over
> Resource?

Good catch! Uploaded as https://codereview.chromium.org/1109663002/

Powered by Google App Engine
This is Rietveld 408576698