Add firefox jsshell support in testing scripts.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 462 matching lines @@
       args = new List.from(args);
       String tempDir = createOutputDirectory(info.filePath, '');
       args.add('--out=$tempDir/out.js');
       List<Command> commands = <Command>[new Command(shellPath(), args)];
       if (info.hasCompileError) {
         // Do not attempt to run the compiled result. A compilation
         // error should be reported by the compilation command.
       } else if (configuration['runtime'] == 'd8') {
         var d8 = TestUtils.d8FileName(configuration);
         commands.add(new Command(d8, ['$tempDir/out.js']));
+      } else if (configuration['runtime'] == 'jsshell') {
+        var jsshell = TestUtils.jsshellFileName(configuration);
+        var environment = TestUtils.jsshellEnvironment(configuration);
+        commands.add(new Command(jsshell, ['$tempDir/out.js'], environment));
       }
       return commands;
 
     case 'dart2dart':
       var compilerArguments = new List.from(args);
       var additionalFlags =
           configuration['additional-compiler-flags'].split(' ');
       for (final flag in additionalFlags) {
         if (flag.isEmpty()) continue;
         compilerArguments.add(flag);
@@ skipping 805 matching lines @@
   static Future copyFile(Path source, Path dest) {
     var output = new File.fromPath(dest).openOutputStream();
     new File.fromPath(source).openInputStream().pipe(output);
     var completer = new Completer();
     output.onClosed = (){ completer.complete(null); };
     return completer.future;
   }
 
   static String executableSuffix(String executable) {
     if (Platform.operatingSystem == 'windows') {
-      if (executable == 'd8' || executable == 'vm' || executable == 'none') {
+      if (executable == 'd8' ||
+          executable == 'vm' ||
+          executable == 'none'  ||
+          executable == 'jsshell') {
         return '.exe';
       } else {
         return '.bat';
       }
     }
     return '';
   }
 
   static String executableName(Map configuration) {
     String suffix = executableSuffix(configuration['compiler']);
@@ skipping 110 matching lines @@
         args.add('--enable-checked-mode');
       }
       // args.add("--verbose");
       if (!isBrowserRuntime(configuration['runtime'])) {
         args.add("--allow-mock-compilation");
       }
     }
     return args;
   }
 
+  static String jsshellDir(Map configuration) {
+    return 'third_party/firefox_jsshell/${configuration['system']}';

[Mads Ager (google), 2012/10/04 11:33:35]

You should make this relative to dartDir which will point to the top of the dart
repo.

[ricow1, 2012/10/04 12:02:05]

We don't do this for d8 or for dart2js, but done

+  }
+
+  static String jsshellFileName(Map configuration) {
+    var executableSuffix = executableSuffix('jsshell');
+    var executable = 'js$executableSuffix';
+    var jsshellDir = jsshellDir(configuration);
+    return '$jsshellDir/$executable';
+  }
+
+  static Map<String, String> jsshellEnvironment(Map configuration) {
+    if (configuration['system'] == 'linux') {

[Mads Ager (google), 2012/10/04 11:33:35]

Do you only need to add something for linux? Does both mac and win search the
current directory for shared libraries?

[ricow1, 2012/10/04 12:02:05]

On windows this worked and as discussed offline this also works on mac

+      var jsshellDir = jsshellDir(configuration);
+      return {'LD_LIBRARY_PATH': jsshellDir};
+    }
+    return {};
+  }
+
   static bool isBrowserRuntime(String runtime) => Contains(
       runtime,
       const <String>['drt',
                      'dartium',
                      'ie',
                      'safari',
                      'opera',
                      'chrome',
                      'ff']);
+
+  static bool isCommandLineRuntime(String runtime) =>

[ahe, 2012/10/04 13:12:26]

isJsCommandLineRuntime?

[ricow1, 2012/10/04 13:19:42]

Done.

+      Contains(runtime, const <String>['d8', 'jsshell']);
+
 }
 
 class SummaryReport {
   static int total = 0;
   static int skipped = 0;
   static int noCrash = 0;
   static int pass = 0;
   static int failOk = 0;
   static int fail = 0;
   static int crash = 0;
@@ skipping 33 matching lines @@
  * $noCrash tests are expected to be flaky but not crash
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
 """;
     print(report);
    }
 }