tools/perf/perf_tools/texture_upload_benchmark.py - Issue 11028021: cc: Improve frame/commit accounting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/perf_tools/texture_upload_benchmark.py

Issue 11028021: cc: Improve frame/commit accounting (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Address comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/perf_tools/scrolling_benchmark_unittest.py ('k') | webkit/compositor_bindings/WebLayerTreeViewImpl.cpp » ('j') | no next file with comments »

OLD	NEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from perf_tools import scrolling_benchmark	4 from perf_tools import scrolling_benchmark

5	5

6 class TextureUploadBenchmark(scrolling_benchmark.ScrollingBenchmark):	6 class TextureUploadBenchmark(scrolling_benchmark.ScrollingBenchmark):

7 def MeasurePage(self, page, tab, results):	7 def MeasurePage(self, page, tab, results):

8 rendering_stats_deltas = self.ScrollPageFully(page, tab)	8 rendering_stats_deltas = self.ScrollPageFully(page, tab)

9	9

10 if (('totalCommitCount' not in rendering_stats_deltas)	10 if (('totalCommitCount' not in rendering_stats_deltas)

11 or rendering_stats_deltas['totalCommitCount'] == 0) :	11 or rendering_stats_deltas['totalCommitCount'] == 0) :

12 averageCommitTimeMs = 0	12 averageCommitTimeMs = 0

13 else :	13 else :

14 averageCommitTimeMs = (	14 averageCommitTimeMs = (

15 1000 * rendering_stats_deltas['totalCommitTimeInSeconds'] /	15 1000 * rendering_stats_deltas['totalCommitTimeInSeconds'] /

16 rendering_stats_deltas['totalCommitCount'])	16 rendering_stats_deltas['totalCommitCount'])

17	17

18 results.Add('texture_upload_count', 'count',	18 results.Add('texture_upload_count', 'count',

19 rendering_stats_deltas['textureUploadCount'])	19 rendering_stats_deltas['textureUploadCount'])

20 results.Add('average_commit_time', 'ms', averageCommitTimeMs)	20 results.Add('average_commit_time', 'ms', averageCommitTimeMs)

	21

	22 commitEfficiency = (

	23 rendering_stats_deltas["totalCommitCount"] /

	24 float(rendering_stats_deltas["vsyncCount"]))

	25 results.Add('commit_efficiency', 'fraction', commitEfficiency)

OLD	NEW