Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: src/incremental-marking.cc

Issue 11028016: Move code flushing support into shared visitor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Ulan Degenbaev. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/mark-compact.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/incremental-marking.cc
diff --git a/src/incremental-marking.cc b/src/incremental-marking.cc
index 4aec1e909123bbb366dd24daef25f5e245c746eb..7ca4c075728d6f31046e25348100997856eb6280 100644
--- a/src/incremental-marking.cc
+++ b/src/incremental-marking.cc
@@ -181,10 +181,6 @@ class IncrementalMarkingMarkingVisitor
static void Initialize() {
StaticMarkingVisitor<IncrementalMarkingMarkingVisitor>::Initialize();
- table_.Register(kVisitSharedFunctionInfo, &VisitSharedFunctionInfo);
-
- table_.Register(kVisitJSFunction, &VisitJSFunction);
-
table_.Register(kVisitJSRegExp, &VisitJSRegExp);
}
@@ -198,16 +194,7 @@ class IncrementalMarkingMarkingVisitor
HeapObject::RawField(object, JSWeakMap::kSize));
}
- static void VisitSharedFunctionInfo(Map* map, HeapObject* object) {
- Heap* heap = map->GetHeap();
- SharedFunctionInfo* shared = SharedFunctionInfo::cast(object);
- if (shared->ic_age() != heap->global_ic_age()) {
- shared->ResetForNewContext(heap->global_ic_age());
- }
- FixedBodyVisitor<IncrementalMarkingMarkingVisitor,
- SharedFunctionInfo::BodyDescriptor,
- void>::Visit(map, object);
- }
+ static void BeforeVisitingSharedFunctionInfo(HeapObject* object) {}
static const int kScanningChunk = 32 * 1024;
@@ -244,25 +231,6 @@ class IncrementalMarkingMarkingVisitor
return to - from;
}
- static inline void VisitJSFunction(Map* map, HeapObject* object) {
- Heap* heap = map->GetHeap();
- // Iterate over all fields in the body but take care in dealing with
- // the code entry and skip weak fields.
- Object** start_slot =
- HeapObject::RawField(object, JSFunction::kPropertiesOffset);
- VisitPointers(heap,
- start_slot,
- start_slot,
- HeapObject::RawField(object, JSFunction::kCodeEntryOffset));
- VisitCodeEntry(heap, object->address() + JSFunction::kCodeEntryOffset);
- VisitPointers(heap,
- start_slot,
- HeapObject::RawField(object,
- JSFunction::kCodeEntryOffset + kPointerSize),
- HeapObject::RawField(object,
- JSFunction::kNonWeakFieldsEndOffset));
- }
-
INLINE(static void VisitPointer(Heap* heap, Object** p)) {
Object* obj = *p;
if (obj->NonFailureIsHeapObject()) {
« no previous file with comments | « no previous file | src/mark-compact.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698