Extend envsetup.sh Clang hack to ASan builds.

Extend envsetup.sh Clang hack to ASan builds.

R=yfriedman@chromium.org,michaelbai@chromium.org
BUG=137569
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=159876

[Yaron, 2012-10-02 17:06:06]

lgtm

[michaelbai, 2012-10-02 17:11:50]

https://codereview.chromium.org/11028014/diff/1/build/android/envsetup.sh
File build/android/envsetup.sh (right):

https://codereview.chromium.org/11028014/diff/1/build/android/envsetup.sh#new...
build/android/envsetup.sh:115: if echo "$GYP_DEFINES" | grep -qE '(clang|asan)';
then
Why did you need this change? Would asan only be set when clang=1?

[eugenis, 2012-10-02 17:23:02]

On Oct 2, 2012 9:11 PM, <michaelbai@chromium.org> wrote:
>
>
> https://codereview.chromium.org/11028014/diff/1/build/android/envsetup.sh
> File build/android/envsetup.sh (right):
>
>
https://codereview.chromium.org/11028014/diff/1/build/android/envsetup.sh#new...
> build/android/envsetup.sh:115: if echo "$GYP_DEFINES" | grep -qE
> '(clang|asan)'; then
> Why did you need this change? Would asan only be set when clang=1?

Asan=1 sets clang=1 in common.gypi.

>
> https://codereview.chromium.org/11028014/

[michaelbai, 2012-10-02 17:28:50]

lgtm

[michaelbai, 2012-10-02 17:37:18]

On 2012/10/02 17:28:50, michaelbai wrote:
> lgtm

BTW, I think ASan=1 makes clang=1 might not proper, as a lot of setting might
only depend on clang=1; assume you set clang=1 early enough, otherwise, it might
lead to potential issue.

[eugenis, 2012-10-03 07:55:55]

On 2012/10/02 17:37:18, michaelbai wrote:
> On 2012/10/02 17:28:50, michaelbai wrote:
> > lgtm
> 
> BTW, I think ASan=1 makes clang=1 might not proper, as a lot of setting might
> only depend on clang=1; assume you set clang=1 early enough, otherwise, it
might
> lead to potential issue.

Yes. I think we do it early enough.
Thanks.

[commit-bot: I haz the power, 2012-10-03 07:56:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eugenis@chromium.org/11028014/1

[commit-bot: I haz the power, 2012-10-03 10:03:21]

Change committed as 159876