bootstrap: Make Eafe work in webview.

bootstrap: Make Eafe work in webview.

BUG=480521
Committed: https://crrev.com/1cd9ca4d513a8847e1099aee4a0c7ff01bb3c50a
Cr-Commit-Position: refs/heads/master@{#326729}

[xiyuan, 2015-04-23 19:30:03]

xiyuan@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Nikita (slow), 2015-04-23 21:14:02]

lgtm

https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:662:
window.setTimeout((function() {
nit: I suppose you can drop window here.

https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:667: }).bind(this),
500);
nit: extract constant.
Are you sure that 500 ms is sufficient timeout for this task?

[xiyuan, 2015-04-23 21:30:48]

https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:662:
window.setTimeout((function() {
On 2015/04/23 21:14:02, Nikita Kostylev wrote:
> nit: I suppose you can drop window here.

Both styles (w/ or w/o window) are used in chromium js code. Personally I prefer
to use more specific names. And I already slipped one window.setTimeout in this
file. :)

https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:667: }).bind(this),
500);
On 2015/04/23 21:14:01, Nikita Kostylev wrote:
> nit: extract constant.
> Are you sure that 500 ms is sufficient timeout for this task?

Constact extracted and added comment.

500ms is an arbitrary number which should be more than enough. Before webview, I
was relying on a message posted up by their UI but that is no longer possible in
webview since we have to postMessage in first.

EAFE is just for prototyping and would be merged into new Gaia. Until then, we
probably can get rid of this message and use just the handshake since clientId
is passed to Gaia via URL param.

[Fady Samuel, 2015-04-23 21:32:21]

On 2015/04/23 21:30:48, xiyuan wrote:
>
https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
> File chrome/browser/resources/gaia_auth_host/authenticator.js (right):
> 
>
https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
> chrome/browser/resources/gaia_auth_host/authenticator.js:662:
> window.setTimeout((function() {
> On 2015/04/23 21:14:02, Nikita Kostylev wrote:
> > nit: I suppose you can drop window here.
> 
> Both styles (w/ or w/o window) are used in chromium js code. Personally I
prefer
> to use more specific names. And I already slipped one window.setTimeout in
this
> file. :)
> 
>
https://codereview.chromium.org/1102793003/diff/1/chrome/browser/resources/ga...
> chrome/browser/resources/gaia_auth_host/authenticator.js:667: }).bind(this),
> 500);
> On 2015/04/23 21:14:01, Nikita Kostylev wrote:
> > nit: extract constant.
> > Are you sure that 500 ms is sufficient timeout for this task?
> 
> Constact extracted and added comment.
> 
> 500ms is an arbitrary number which should be more than enough. Before webview,
I
> was relying on a message posted up by their UI but that is no longer possible
in
> webview since we have to postMessage in first.
> 


Can you inject script that intercept a first postMessage, and saves the
event.source? Once you save that variable in the embedded content, you can
postMessage back up whenever you'd like.


> EAFE is just for prototyping and would be merged into new Gaia. Until then, we
> probably can get rid of this message and use just the handshake since clientId
> is passed to Gaia via URL param.

[xiyuan, 2015-04-23 21:49:10]

On 2015/04/23 21:32:21, Fady Samuel wrote:
> Can you inject script that intercept a first postMessage, and saves the
> event.source? Once you save that variable in the embedded content, you can
> postMessage back up whenever you'd like.
> 

The EAFE pages is already doing that. However, they are using some framework and
might not be listening to 'message' when their window is loaded. The listener is
added sometime later, similar to what we have for Gaia in
http://crbug.com/479136. It is for proof of concept so I did not push to get it
fixed.

[xiyuan, 2015-04-24 01:03:28]

The CQ bit was checked by xiyuan@chromium.org

[xiyuan, 2015-04-24 01:03:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
nkostylev@chromium.org
Link to the patchset: https://codereview.chromium.org/1102793003/#ps20001
(title: "for #1")

[commit-bot: I haz the power, 2015-04-24 01:03:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102793003/20001

[commit-bot: I haz the power, 2015-04-24 01:10:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-24 01:10:46]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[xiyuan, 2015-04-24 02:40:33]

The CQ bit was checked by xiyuan@chromium.org

[commit-bot: I haz the power, 2015-04-24 02:41:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102793003/20001

[commit-bot: I haz the power, 2015-04-24 02:47:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-24 02:48:58]

Patchset 2 (id:??) landed as
https://crrev.com/1cd9ca4d513a8847e1099aee4a0c7ff01bb3c50a
Cr-Commit-Position: refs/heads/master@{#326729}