Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1102753002: [Android] Refactor Java Bridge tests (Closed)

Created:
5 years, 8 months ago by mnaganov (inactive)
Modified:
5 years, 7 months ago
Reviewers:
Ted C, Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Refactor Java Bridge tests This is to bring in some sanity, and to facilitate extracting common test code to be used by both ContentShellTests and AwShellTests. BUG=476880 Committed: https://crrev.com/af92aa448207e95fe7c4c0fd52e5d4e03d6f6d2c Cr-Commit-Position: refs/heads/master@{#327294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -133 lines) Patch
D content/public/android/javatests/src/org/chromium/content/browser/ContentViewTestBase.java View 1 chunk +0 lines, -64 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayCoercionTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeArrayTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java View 6 chunks +4 lines, -60 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 3 chunks +12 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeFieldsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeReturnValuesTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeTestBase.java View 2 chunks +77 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ViewportTest.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
mnaganov (inactive)
5 years, 8 months ago (2015-04-23 11:41:00 UTC) #2
mnaganov (inactive)
Ping!
5 years, 8 months ago (2015-04-24 11:58:23 UTC) #3
Torne
lgtm
5 years, 7 months ago (2015-04-27 15:30:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102753002/1
5 years, 7 months ago (2015-04-27 20:29:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/59335)
5 years, 7 months ago (2015-04-27 20:38:47 UTC) #8
mnaganov (inactive)
tedchoc@: Hi Ted, can you please make an OWNER's review?
5 years, 7 months ago (2015-04-27 21:33:57 UTC) #10
Ted C
lgtm
5 years, 7 months ago (2015-04-27 22:48:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102753002/1
5 years, 7 months ago (2015-04-28 15:55:09 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 15:58:21 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 15:59:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af92aa448207e95fe7c4c0fd52e5d4e03d6f6d2c
Cr-Commit-Position: refs/heads/master@{#327294}

Powered by Google App Engine
This is Rietveld 408576698