chrome/browser/signin/about_signin_internals_factory.cc - Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/about_signin_internals_factory.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search_engines/template_url_service_factory.cc ('k') | chrome/browser/signin/account_tracker_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/about_signin_internals_factory.cc

diff --git a/chrome/browser/signin/about_signin_internals_factory.cc b/chrome/browser/signin/about_signin_internals_factory.cc

index e20918245799f39b59b9c1fd2921adaf953b7043..5d77ec827792fedf9d902961335b2694d37e8c93 100644

--- a/chrome/browser/signin/about_signin_internals_factory.cc

+++ b/chrome/browser/signin/about_signin_internals_factory.cc

@@ -58,10 +58,7 @@ void AboutSigninInternalsFactory::RegisterProfilePrefs(

for (int i = UNTIMED_FIELDS_BEGIN; i < UNTIMED_FIELDS_END; ++i) {

const std::string pref_path = SigninStatusFieldToString(

static_cast<UntimedSigninStatusField>(i));

- user_prefs->RegisterStringPref(

- pref_path.c_str(),

- std::string(),

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

+ user_prefs->RegisterStringPref(pref_path.c_str(), std::string());

}

for (int i = TIMED_FIELDS_BEGIN; i < TIMED_FIELDS_END; ++i) {

@@ -69,14 +66,8 @@ void AboutSigninInternalsFactory::RegisterProfilePrefs(

static_cast<TimedSigninStatusField>(i)) + ".value";

const std::string time = SigninStatusFieldToString(

static_cast<TimedSigninStatusField>(i)) + ".time";

- user_prefs->RegisterStringPref(

- value.c_str(),

- std::string(),

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

- user_prefs->RegisterStringPref(

- time.c_str(),

- std::string(),

- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

+ user_prefs->RegisterStringPref(value.c_str(), std::string());

+ user_prefs->RegisterStringPref(time.c_str(), std::string());

}