Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: components/sync_driver/sync_prefs.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_driver/sync_prefs.h" 5 #include "components/sync_driver/sync_prefs.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/prefs/pref_member.h" 8 #include "base/prefs/pref_member.h"
9 #include "base/prefs/pref_service.h" 9 #include "base/prefs/pref_service.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 17 matching lines...) Expand all
28 base::Bind(&SyncPrefs::OnSyncManagedPrefChanged, base::Unretained(this))); 28 base::Bind(&SyncPrefs::OnSyncManagedPrefChanged, base::Unretained(this)));
29 } 29 }
30 30
31 SyncPrefs::SyncPrefs() : pref_service_(NULL) {} 31 SyncPrefs::SyncPrefs() : pref_service_(NULL) {}
32 32
33 SyncPrefs::~SyncPrefs() { DCHECK(CalledOnValidThread()); } 33 SyncPrefs::~SyncPrefs() { DCHECK(CalledOnValidThread()); }
34 34
35 // static 35 // static
36 void SyncPrefs::RegisterProfilePrefs( 36 void SyncPrefs::RegisterProfilePrefs(
37 user_prefs::PrefRegistrySyncable* registry) { 37 user_prefs::PrefRegistrySyncable* registry) {
38 registry->RegisterBooleanPref( 38 registry->RegisterBooleanPref(prefs::kSyncHasSetupCompleted, false);
39 prefs::kSyncHasSetupCompleted, 39 registry->RegisterBooleanPref(prefs::kSyncSuppressStart, false);
40 false, 40 registry->RegisterInt64Pref(prefs::kSyncLastSyncedTime, 0);
41 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 41 registry->RegisterInt64Pref(prefs::kSyncFirstSyncTime, 0);
42 registry->RegisterBooleanPref(
43 prefs::kSyncSuppressStart,
44 false,
45 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
46 registry->RegisterInt64Pref(
47 prefs::kSyncLastSyncedTime,
48 0,
49 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
50 registry->RegisterInt64Pref(
51 prefs::kSyncFirstSyncTime,
52 0,
53 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
54 42
55 // All datatypes are on by default, but this gets set explicitly 43 // All datatypes are on by default, but this gets set explicitly
56 // when you configure sync (when turning it on), in 44 // when you configure sync (when turning it on), in
57 // ProfileSyncService::OnUserChoseDatatypes. 45 // ProfileSyncService::OnUserChoseDatatypes.
58 registry->RegisterBooleanPref( 46 registry->RegisterBooleanPref(prefs::kSyncKeepEverythingSynced, true);
59 prefs::kSyncKeepEverythingSynced,
60 true,
61 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
62 47
63 syncer::ModelTypeSet user_types = syncer::UserTypes(); 48 syncer::ModelTypeSet user_types = syncer::UserTypes();
64 49
65 // Include proxy types as well, as they can be individually selected, 50 // Include proxy types as well, as they can be individually selected,
66 // although they don't have sync representations. 51 // although they don't have sync representations.
67 user_types.PutAll(syncer::ProxyTypes()); 52 user_types.PutAll(syncer::ProxyTypes());
68 53
69 // Treat bookmarks and device info specially. 54 // Treat bookmarks and device info specially.
70 RegisterDataTypePreferredPref(registry, syncer::BOOKMARKS, true); 55 RegisterDataTypePreferredPref(registry, syncer::BOOKMARKS, true);
71 RegisterDataTypePreferredPref(registry, syncer::DEVICE_INFO, true); 56 RegisterDataTypePreferredPref(registry, syncer::DEVICE_INFO, true);
72 user_types.Remove(syncer::BOOKMARKS); 57 user_types.Remove(syncer::BOOKMARKS);
73 user_types.Remove(syncer::DEVICE_INFO); 58 user_types.Remove(syncer::DEVICE_INFO);
74 59
75 // All types are set to off by default, which forces a configuration to 60 // All types are set to off by default, which forces a configuration to
76 // explicitly enable them. GetPreferredTypes() will ensure that any new 61 // explicitly enable them. GetPreferredTypes() will ensure that any new
77 // implicit types are enabled when their pref group is, or via 62 // implicit types are enabled when their pref group is, or via
78 // KeepEverythingSynced. 63 // KeepEverythingSynced.
79 for (syncer::ModelTypeSet::Iterator it = user_types.First(); it.Good(); 64 for (syncer::ModelTypeSet::Iterator it = user_types.First(); it.Good();
80 it.Inc()) { 65 it.Inc()) {
81 RegisterDataTypePreferredPref(registry, it.Get(), false); 66 RegisterDataTypePreferredPref(registry, it.Get(), false);
82 } 67 }
83 68
84 registry->RegisterBooleanPref( 69 registry->RegisterBooleanPref(prefs::kSyncManaged, false);
85 prefs::kSyncManaged, 70 registry->RegisterStringPref(prefs::kSyncEncryptionBootstrapToken,
86 false, 71 std::string());
87 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF); 72 registry->RegisterStringPref(prefs::kSyncKeystoreEncryptionBootstrapToken,
88 registry->RegisterStringPref( 73 std::string());
89 prefs::kSyncEncryptionBootstrapToken,
90 std::string(),
91 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
92 registry->RegisterStringPref(
93 prefs::kSyncKeystoreEncryptionBootstrapToken,
94 std::string(),
95 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
96 #if defined(OS_CHROMEOS) 74 #if defined(OS_CHROMEOS)
97 registry->RegisterStringPref( 75 registry->RegisterStringPref(prefs::kSyncSpareBootstrapToken, "");
98 prefs::kSyncSpareBootstrapToken,
99 "",
100 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
101 #endif 76 #endif
102 77
103 registry->RegisterBooleanPref( 78 registry->RegisterBooleanPref(prefs::kSyncHasAuthError, false);
104 prefs::kSyncHasAuthError,
105 false,
106 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
107 79
108 registry->RegisterStringPref( 80 registry->RegisterStringPref(prefs::kSyncSessionsGUID, std::string());
109 prefs::kSyncSessionsGUID,
110 std::string(),
111 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
112 81
113 registry->RegisterIntegerPref( 82 registry->RegisterIntegerPref(prefs::kSyncRemainingRollbackTries, 0);
114 prefs::kSyncRemainingRollbackTries, 0,
115 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
116 } 83 }
117 84
118 void SyncPrefs::AddSyncPrefObserver(SyncPrefObserver* sync_pref_observer) { 85 void SyncPrefs::AddSyncPrefObserver(SyncPrefObserver* sync_pref_observer) {
119 DCHECK(CalledOnValidThread()); 86 DCHECK(CalledOnValidThread());
120 sync_pref_observers_.AddObserver(sync_pref_observer); 87 sync_pref_observers_.AddObserver(sync_pref_observer);
121 } 88 }
122 89
123 void SyncPrefs::RemoveSyncPrefObserver(SyncPrefObserver* sync_pref_observer) { 90 void SyncPrefs::RemoveSyncPrefObserver(SyncPrefObserver* sync_pref_observer) {
124 DCHECK(CalledOnValidThread()); 91 DCHECK(CalledOnValidThread());
125 sync_pref_observers_.RemoveObserver(sync_pref_observer); 92 sync_pref_observers_.RemoveObserver(sync_pref_observer);
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 // static 354 // static
388 void SyncPrefs::RegisterDataTypePreferredPref( 355 void SyncPrefs::RegisterDataTypePreferredPref(
389 user_prefs::PrefRegistrySyncable* registry, 356 user_prefs::PrefRegistrySyncable* registry,
390 syncer::ModelType type, 357 syncer::ModelType type,
391 bool is_preferred) { 358 bool is_preferred) {
392 const char* pref_name = GetPrefNameForDataType(type); 359 const char* pref_name = GetPrefNameForDataType(type);
393 if (!pref_name) { 360 if (!pref_name) {
394 NOTREACHED(); 361 NOTREACHED();
395 return; 362 return;
396 } 363 }
397 registry->RegisterBooleanPref( 364 registry->RegisterBooleanPref(pref_name, is_preferred);
398 pref_name,
399 is_preferred,
400 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
401 } 365 }
402 366
403 bool SyncPrefs::GetDataTypePreferred(syncer::ModelType type) const { 367 bool SyncPrefs::GetDataTypePreferred(syncer::ModelType type) const {
404 DCHECK(CalledOnValidThread()); 368 DCHECK(CalledOnValidThread());
405 const char* pref_name = GetPrefNameForDataType(type); 369 const char* pref_name = GetPrefNameForDataType(type);
406 if (!pref_name) { 370 if (!pref_name) {
407 NOTREACHED(); 371 NOTREACHED();
408 return false; 372 return false;
409 } 373 }
410 374
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
461 425
462 void SyncPrefs::SetFirstSyncTime(base::Time time) { 426 void SyncPrefs::SetFirstSyncTime(base::Time time) {
463 pref_service_->SetInt64(prefs::kSyncFirstSyncTime, time.ToInternalValue()); 427 pref_service_->SetInt64(prefs::kSyncFirstSyncTime, time.ToInternalValue());
464 } 428 }
465 429
466 void SyncPrefs::ClearFirstSyncTime() { 430 void SyncPrefs::ClearFirstSyncTime() {
467 pref_service_->ClearPref(prefs::kSyncFirstSyncTime); 431 pref_service_->ClearPref(prefs::kSyncFirstSyncTime);
468 } 432 }
469 433
470 } // namespace sync_driver 434 } // namespace sync_driver
OLDNEW
« no previous file with comments | « components/suggestions/suggestions_store.cc ('k') | components/translate/core/browser/translate_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698