Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: chrome/browser/profiles/chrome_version_service.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/profiles/chrome_version_service.h" 5 #include "chrome/browser/profiles/chrome_version_service.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/version.h" 8 #include "base/version.h"
9 #include "chrome/common/chrome_version_info.h" 9 #include "chrome/common/chrome_version_info.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
11 #include "components/pref_registry/pref_registry_syncable.h" 11 #include "components/pref_registry/pref_registry_syncable.h"
12 12
13 // static 13 // static
14 void ChromeVersionService::RegisterProfilePrefs( 14 void ChromeVersionService::RegisterProfilePrefs(
15 user_prefs::PrefRegistrySyncable* registry) { 15 user_prefs::PrefRegistrySyncable* registry) {
16 registry->RegisterStringPref( 16 registry->RegisterStringPref(prefs::kProfileCreatedByVersion, "1.0.0.0");
17 prefs::kProfileCreatedByVersion,
18 "1.0.0.0",
19 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
20 } 17 }
21 18
22 // static 19 // static
23 void ChromeVersionService::SetVersion(PrefService* prefs, 20 void ChromeVersionService::SetVersion(PrefService* prefs,
24 const std::string& version) { 21 const std::string& version) {
25 prefs->SetString(prefs::kProfileCreatedByVersion, version); 22 prefs->SetString(prefs::kProfileCreatedByVersion, version);
26 } 23 }
27 24
28 // static 25 // static
29 std::string ChromeVersionService::GetVersion(PrefService* prefs) { 26 std::string ChromeVersionService::GetVersion(PrefService* prefs) {
30 return prefs->GetString(prefs::kProfileCreatedByVersion); 27 return prefs->GetString(prefs::kProfileCreatedByVersion);
31 } 28 }
32 29
33 // static 30 // static
34 void ChromeVersionService::OnProfileLoaded(PrefService* prefs, 31 void ChromeVersionService::OnProfileLoaded(PrefService* prefs,
35 bool is_new_profile) { 32 bool is_new_profile) {
36 // Obtain the Chrome version info. 33 // Obtain the Chrome version info.
37 chrome::VersionInfo version_info; 34 chrome::VersionInfo version_info;
38 35
39 // If this is a new profile set version to current version, otherwise 36 // If this is a new profile set version to current version, otherwise
40 // (pre-existing profile), leave pref at default value (1.0.0.0) to 37 // (pre-existing profile), leave pref at default value (1.0.0.0) to
41 // avoid any first-run behavior. 38 // avoid any first-run behavior.
42 std::string version = version_info.Version(); 39 std::string version = version_info.Version();
43 if (prefs->FindPreference(prefs::kProfileCreatedByVersion)-> 40 if (prefs->FindPreference(prefs::kProfileCreatedByVersion)->
44 IsDefaultValue() && is_new_profile) { 41 IsDefaultValue() && is_new_profile) {
45 SetVersion(prefs, version); 42 SetVersion(prefs, version);
46 } 43 }
47 } 44 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698