Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/prefs/prefs_syncable_service_unittest.cc

Issue 1102733002: Remove most occurences of PrefRegistrySyncable::UNSYNCABLE_PREF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@prefs-add-reg-funcs
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/json/json_reader.h" 5 #include "base/json/json_reader.h"
6 #include "base/json/json_string_value_serializer.h" 6 #include "base/json/json_string_value_serializer.h"
7 #include "base/json/json_writer.h" 7 #include "base/json/json_writer.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/prefs/scoped_user_pref_update.h" 9 #include "base/prefs/scoped_user_pref_update.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 }; 68 };
69 69
70 class PrefsSyncableServiceTest : public testing::Test { 70 class PrefsSyncableServiceTest : public testing::Test {
71 public: 71 public:
72 PrefsSyncableServiceTest() : 72 PrefsSyncableServiceTest() :
73 pref_sync_service_(NULL), 73 pref_sync_service_(NULL),
74 test_processor_(NULL), 74 test_processor_(NULL),
75 next_pref_remote_sync_node_id_(0) {} 75 next_pref_remote_sync_node_id_(0) {}
76 76
77 void SetUp() override { 77 void SetUp() override {
78 prefs_.registry()->RegisterStringPref( 78 prefs_.registry()->RegisterStringPref(kUnsyncedPreferenceName,
79 kUnsyncedPreferenceName, 79 kUnsyncedPreferenceDefaultValue);
80 kUnsyncedPreferenceDefaultValue,
81 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
82 prefs_.registry()->RegisterStringPref( 80 prefs_.registry()->RegisterStringPref(
83 prefs::kHomePage, 81 prefs::kHomePage,
84 std::string(), 82 std::string(),
85 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 83 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
86 prefs_.registry()->RegisterListPref( 84 prefs_.registry()->RegisterListPref(
87 prefs::kURLsToRestoreOnStartup, 85 prefs::kURLsToRestoreOnStartup,
88 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 86 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
89 prefs_.registry()->RegisterListPref( 87 prefs_.registry()->RegisterListPref(prefs::kURLsToRestoreOnStartupOld);
90 prefs::kURLsToRestoreOnStartupOld,
91 user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
92 prefs_.registry()->RegisterStringPref( 88 prefs_.registry()->RegisterStringPref(
93 prefs::kDefaultCharset, 89 prefs::kDefaultCharset,
94 l10n_util::GetStringUTF8(IDS_DEFAULT_ENCODING), 90 l10n_util::GetStringUTF8(IDS_DEFAULT_ENCODING),
95 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF); 91 user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
96 92
97 pref_sync_service_ = reinterpret_cast<PrefModelAssociator*>( 93 pref_sync_service_ = reinterpret_cast<PrefModelAssociator*>(
98 prefs_.GetSyncableService(syncer::PREFERENCES)); 94 prefs_.GetSyncableService(syncer::PREFERENCES));
99 ASSERT_TRUE(pref_sync_service_); 95 ASSERT_TRUE(pref_sync_service_);
100 next_pref_remote_sync_node_id_ = 0; 96 next_pref_remote_sync_node_id_ = 0;
101 } 97 }
(...skipping 613 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 711
716 InitWithNoSyncData(); 712 InitWithNoSyncData();
717 713
718 scoped_ptr<base::Value> null_value(base::Value::CreateNullValue()); 714 scoped_ptr<base::Value> null_value(base::Value::CreateNullValue());
719 syncer::SyncChangeList list; 715 syncer::SyncChangeList list;
720 list.push_back(MakeRemoteChange( 716 list.push_back(MakeRemoteChange(
721 1, prefs::kHomePage, *null_value, SyncChange::ACTION_DELETE)); 717 1, prefs::kHomePage, *null_value, SyncChange::ACTION_DELETE));
722 pref_sync_service_->ProcessSyncChanges(FROM_HERE, list); 718 pref_sync_service_->ProcessSyncChanges(FROM_HERE, list);
723 EXPECT_TRUE(pref->IsDefaultValue()); 719 EXPECT_TRUE(pref->IsDefaultValue());
724 } 720 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/incognito_mode_prefs.cc ('k') | chrome/browser/prefs/profile_pref_store_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698