Issue 110273006: Show better CORS error message when status code is not set

Issue 110273006: Show better CORS error message when status code is not set (Closed)

Created:
6 years, 11 months ago by tyoshino (SeeGerritForStatus)

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Show better CORS error message when status code is not set When no response is received for a CORS request, Blink shows a misleading message saying "No Access-Control-Allow-Origin header is present". This change makes Blink say that "no valid response is received". BUG=327834 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164744

Patch Set 1 #

Patch Set 2 : Changed to just reorder passesPreflightStatusCheck call and passesAccessControlCheck call #

Patch Set 3 : Changed to just compare with 0 #

Patch Set 4 : Fixed tests #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -0 lines)			Patch
	M	Source/core/fetch/CrossOriginAccessControl.cpp	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	Source/web/tests/AssociatedURLLoaderTest.cpp	View	1 2 3	9 chunks	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/110273006/70001

6 years, 11 months ago (2014-01-07 09:53:06 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=16543

6 years, 11 months ago (2014-01-07 10:57:35 UTC) #4

tyoshino (SeeGerritForStatus)

Adam, Sorry I forgot to update AssociatedURLLoaderTest.cpp. Could you please take another look at it?

6 years, 11 months ago (2014-01-09 05:43:14 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/110273006/250001

6 years, 11 months ago (2014-01-09 06:10:12 UTC) #7

Message was sent while issue was closed.

Change committed as 164744

Expand Messages | Collapse Messages