Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 110273004: Make sdch not use an incompatible stdint.h. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Make sdch not use an incompatible stdint.h. We force-include our own logging.h, which includes basictypes.h, which now includes stdint.h. Without this change, this ends up being minimal/hacky stdint.h (from sdch/open-vcdiff/vsprojects), which isn't sufficient for the needs of the rest of basictypes.h. R=brettw@chromium.org, jar@chromium.org BUG=138542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243329

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M base/basictypes.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sdch/README.chromium View 1 chunk +4 lines, -0 lines 0 comments Download
M sdch/sdch.gyp View 1 chunk +1 line, -1 line 0 comments Download
A sdch/win/config.h View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
viettrungluu
Please review, assuming it compiles.
6 years, 11 months ago (2014-01-07 01:24:16 UTC) #1
jar (doing other things)
+cc openvcdiff
6 years, 11 months ago (2014-01-07 01:56:56 UTC) #2
jar (doing other things)
The changes LGTM... but brett will need to approve base, and Lincoln might comment on ...
6 years, 11 months ago (2014-01-07 03:06:23 UTC) #3
brettw
lgtm
6 years, 11 months ago (2014-01-07 05:12:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/110273004/1
6 years, 11 months ago (2014-01-07 09:53:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242350
6 years, 11 months ago (2014-01-07 12:41:34 UTC) #6
Lincoln
On 2014/01/07 03:06:23, jar wrote: > The changes LGTM... but brett will need to approve ...
6 years, 11 months ago (2014-01-07 16:33:02 UTC) #7
viettrungluu
6 years, 11 months ago (2014-01-07 17:51:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r243329 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698