Chromium Code Reviews| Index: chrome/common/json_pref_store.h |
| diff --git a/chrome/common/json_pref_store.h b/chrome/common/json_pref_store.h |
| index 7ceb7dad2ac0c472e51a1405e58861e6fd6ad93a..39100fa1f09e805dcbab982f17439af530a1becd 100644 |
| --- a/chrome/common/json_pref_store.h |
| +++ b/chrome/common/json_pref_store.h |
| @@ -18,7 +18,8 @@ |
| namespace base { |
| class DictionaryValue; |
| -class MessageLoopProxy; |
| +class SequencedWorkerPool; |
| +class SequencedTaskRunner; |
| class Value; |
| } |
| @@ -28,10 +29,17 @@ class FilePath; |
| class JsonPrefStore : public PersistentPrefStore, |
| public ImportantFileWriter::DataSerializer { |
| public: |
| - // |file_message_loop_proxy| is the MessageLoopProxy for a thread on which |
| - // file I/O can be done. |
| - JsonPrefStore(const FilePath& pref_filename, |
| - base::MessageLoopProxy* file_message_loop_proxy); |
| + // Returns instance of SequencedTaskRunner which guarantees that file |
| + // operations on the same file will be executes in sequenced order. |
|
akalin
2012/10/18 23:52:24
executes -> executed
zel
2012/10/19 01:20:32
Done.
|
| + static scoped_refptr<base::SequencedTaskRunner> GetTaskRunnerForFile( |
| + const FilePath& pref_filename, |
| + base::SequencedWorkerPool* worker_pool); |
| + |
| + // Creates an instance JsonPrefStore for a given |pref_filename| that will |
| + // perform all file I/O operations on |sequenced_task_runner|. |
| + static JsonPrefStore* Create( |
| + const FilePath& pref_filename, |
| + base::SequencedTaskRunner* sequenced_task_runner); |
| // PrefStore overrides: |
| virtual ReadResult GetValue(const std::string& key, |
| @@ -63,13 +71,16 @@ class JsonPrefStore : public PersistentPrefStore, |
| void OnFileRead(base::Value* value_owned, PrefReadError error, bool no_dir); |
| private: |
| + // |task_runner| is the TaskRunner for a thread on which file I/O can be done. |
| + JsonPrefStore(const FilePath& pref_filename, |
| + base::SequencedTaskRunner* sequenced_task_runner); |
| virtual ~JsonPrefStore(); |
| // ImportantFileWriter::DataSerializer overrides: |
| virtual bool SerializeData(std::string* output) OVERRIDE; |
| FilePath path_; |
| - scoped_refptr<base::MessageLoopProxy> file_message_loop_proxy_; |
| + scoped_refptr<base::SequencedTaskRunner> sequenced_task_runner_; |
| scoped_ptr<base::DictionaryValue> prefs_; |