Faster 64-bit right-shift for the ia32 compiler.

runtime/vm/disassembler_ia32.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 #include "platform/utils.h"
 #include "vm/allocation.h"
@@ skipping 742 matching lines @@
   uint8_t cond = *(data + 1) & 0x0F;
   const char* mnem = conditional_move_mnem[cond];
   int op_size = PrintOperands(mnem, REG_OPER_OP_ORDER, data + 2);
   return 2 + op_size;  // includes 0x0F
 }
 
 
 int X86Decoder::D1D3C1Instruction(uint8_t* data) {
   uint8_t op = *data;
   ASSERT(op == 0xD1 || op == 0xD3 || op == 0xC1);
-  uint8_t modrm = *(data+1);
   int mod, regop, rm;
-  GetModRm(modrm, &mod, &regop, &rm);
-  int imm8 = -1;
-  int num_bytes = 2;
-  if (mod == 3) {
-    const char* mnem = NULL;
-    if (op == 0xD1) {
-      imm8 = 1;
-      switch (regop) {
-        case edx: mnem = "rcl"; break;
-        case edi: mnem = "sar"; break;
-        case esp: mnem = "shl"; break;
-        case ebp: mnem = "shr"; break;
-        default: UNIMPLEMENTED();
-      }
-    } else if (op == 0xC1) {
-      imm8 = *(data+2);
-      num_bytes = 3;
-      switch (regop) {
-        case edx: mnem = "rcl"; break;
-        case esp: mnem = "shl"; break;
-        case ebp: mnem = "shr"; break;
-        case edi: mnem = "sar"; break;
-        default: UNIMPLEMENTED();
-      }
-    } else if (op == 0xD3) {
-      switch (regop) {
-        case esp: mnem = "shl"; break;
-        case ebp: mnem = "shr"; break;
-        case edi: mnem = "sar"; break;
-        default: UNIMPLEMENTED();
-      }
-    }
-    ASSERT(mnem != NULL);
-    Print(mnem);
-    Print(" ");
-    PrintCPURegister(rm);
-    Print(",");
-    if (imm8 > 0) {
-      PrintInt(imm8);
-    } else {
-      Print("cl");
-    }
+  GetModRm(*(data+1), &mod, &regop, &rm);
+  int num_bytes = 1;
+  const char* mnem = NULL;
+  switch (regop) {
+    case 2: mnem = "rcl"; break;
+    case 4: mnem = "shl"; break;
+    case 5: mnem = "shr"; break;
+    case 7: mnem = "sar"; break;
+    default: UNIMPLEMENTED();
+  }
+  ASSERT(mnem != NULL);
+  Print(mnem);
+  Print(" ");
+
+  if (op == 0xD1) {
+    num_bytes += PrintRightOperand(data+1);
+    Print(", 1");
+  } else if (op == 0xC1) {
+    num_bytes += PrintRightOperand(data+1);
+    Print(", ");
+    PrintInt(*(data+2));
+    num_bytes++;
   } else {
-    UNIMPLEMENTED();
+    ASSERT(op == 0xD3);
+    num_bytes += PrintRightOperand(data+1);
+    Print(", cl");
   }
   return num_bytes;
 }
 
 
 uint8_t* X86Decoder::F3Instruction(uint8_t* data) {
   if (*(data+1) == 0x0F) {
     uint8_t b2 = *(data+2);
     switch (b2) {
       case 0x2C: {
@@ skipping 510 matching lines @@
           } else {
             UNIMPLEMENTED();
           }
         } else {
           data += 2;
           if (f0byte == 0xAB || f0byte == 0xA5 || f0byte == 0xAD) {
             // shrd, shld, bts
             Print(f0mnem);
             int mod, regop, rm;
             GetModRm(*data, &mod, &regop, &rm);
+            Print(" ");
             data += PrintRightOperand(data);
             if (f0byte == 0xAB) {
               Print(",");
               PrintCPURegister(regop);
             } else {
               Print(",");
               PrintCPURegister(regop);
               Print(",cl");
             }
           } else if (f0byte == 0x28) {
@@ skipping 369 matching lines @@
                                   human_buffer,
                                   sizeof(human_buffer),
                                   pc);
     pc += instruction_length;
   }
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32