Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 11027026: Renaming Unboxed* IL instructions to shorter names. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: fixed indentation Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 13224)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -545,18 +545,15 @@
call->env(),
Definition::kEffect);
- UnboxedDoubleBinaryOpInstr* double_bin_op =
- new UnboxedDoubleBinaryOpInstr(op_kind,
- left->Copy(),
- right->Copy(),
- call);
+ BinaryDoubleOpInstr* double_bin_op =
+ new BinaryDoubleOpInstr(op_kind, left->Copy(), right->Copy(), call);
call->ReplaceWith(double_bin_op, current_iterator());
RemovePushArguments(call);
} else if (operands_type == kMintCid) {
Value* left = call->ArgumentAt(0)->value();
Value* right = call->ArgumentAt(1)->value();
- UnboxedMintBinaryOpInstr* bin_op =
- new UnboxedMintBinaryOpInstr(op_kind, left, right, call);
+ BinaryMintOpInstr* bin_op =
+ new BinaryMintOpInstr(op_kind, left, right, call);
call->ReplaceWith(bin_op, current_iterator());
RemovePushArguments(call);
} else if (op_kind == Token::kMOD) {
@@ -620,7 +617,7 @@
HasOnlySmiOrMint(*call->ic_data()) &&
FlowGraphCompiler::SupportsUnboxedMints()) {
Value* value = call->ArgumentAt(0)->value();
- unary_op = new UnboxedMintUnaryOpInstr(op_kind, value, call);
+ unary_op = new UnaryMintOpInstr(op_kind, value, call);
} else if (HasOnlyOneDouble(*call->ic_data()) &&
(op_kind == Token::kNEGATE)) {
Value* value = call->ArgumentAt(0)->value();
@@ -628,10 +625,10 @@
ConstantInstr* minus_one =
new ConstantInstr(Double::ZoneHandle(Double::NewCanonical(-1)));
InsertBefore(call, minus_one, NULL, Definition::kValue);
- unary_op = new UnboxedDoubleBinaryOpInstr(Token::kMUL,
- value,
- new Value(minus_one),
- call);
+ unary_op = new BinaryDoubleOpInstr(Token::kMUL,
+ value,
+ new Value(minus_one),
+ call);
}
if (unary_op == NULL) return false;
@@ -2921,15 +2918,15 @@
}
-void ConstantPropagator::VisitUnboxedMintBinaryOp(
- UnboxedMintBinaryOpInstr* instr) {
+void ConstantPropagator::VisitBinaryMintOp(
+ BinaryMintOpInstr* instr) {
// TODO(kmillikin): Handle binary operations.
SetValue(instr, non_constant_);
}
-void ConstantPropagator::VisitUnboxedMintUnaryOp(
- UnboxedMintUnaryOpInstr* instr) {
+void ConstantPropagator::VisitUnaryMintOp(
+ UnaryMintOpInstr* instr) {
// TODO(kmillikin): Handle unary operations.
SetValue(instr, non_constant_);
}
@@ -2974,8 +2971,8 @@
}
-void ConstantPropagator::VisitUnboxedDoubleBinaryOp(
- UnboxedDoubleBinaryOpInstr* instr) {
+void ConstantPropagator::VisitBinaryDoubleOp(
+ BinaryDoubleOpInstr* instr) {
const Object& left = instr->left()->definition()->constant_value();
const Object& right = instr->right()->definition()->constant_value();
if (IsNonConstant(left) || IsNonConstant(right)) {
« no previous file with comments | « no previous file | runtime/vm/il_printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698