Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: content/browser/presentation/presentation_service_impl.h

Issue 1102683002: Revert of [Presentation API] Implement ondefaultsessionstart in PSImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/presentation/presentation_service_impl.h
diff --git a/content/browser/presentation/presentation_service_impl.h b/content/browser/presentation/presentation_service_impl.h
index 21de733b7b0cab9558f7b9feff54661c7d687961..84962e7ae8bd5443681f7bb3a79e59cc72f70f3b 100644
--- a/content/browser/presentation/presentation_service_impl.h
+++ b/content/browser/presentation/presentation_service_impl.h
@@ -109,27 +109,6 @@
scoped_ptr<bool> available_ptr_;
};
- class CONTENT_EXPORT DefaultSessionStartContext {
- public:
- DefaultSessionStartContext();
- ~DefaultSessionStartContext();
-
- // Adds a callback. May invoke the callback immediately if |session| using
- // default presentation URL was already started.
- void AddCallback(const DefaultSessionMojoCallback& callback);
-
- // Sets the session info. Maybe invoke callbacks queued with AddCallback().
- void set_session(const PresentationSessionInfo& session);
-
- private:
- // Flush all queued callbacks by invoking them with null
- // PresentationSessionInfoPtr.
- void Reset();
-
- ScopedVector<DefaultSessionMojoCallback> callbacks_;
- scoped_ptr<PresentationSessionInfo> session_;
- };
-
// Context for a StartSession request.
class CONTENT_EXPORT StartSessionRequest {
public:
@@ -167,12 +146,6 @@
SetSameDefaultPresentationUrl);
FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
ClearDefaultPresentationUrl);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForDefaultSessionStart);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- ListenForDefaultSessionStartAfterSet);
- FRIEND_TEST_ALL_PREFIXES(PresentationServiceImplTest,
- DefaultSessionStartReset);
// |render_frame_host|: The RFH this instance is associated with.
// |web_contents|: The WebContents to observe.
@@ -224,8 +197,6 @@
// PresentationServiceDelegate::Observer
void OnDelegateDestroyed() override;
- void OnDefaultPresentationStarted(const PresentationSessionInfo& session)
- override;
// Finds the callback from |pending_session_cbs_| using |request_session_id|.
// If it exists, invoke it with |session| and |error|, then erase it from
@@ -285,9 +256,7 @@
ScreenAvailabilityContext* GetOrCreateAvailabilityContext(
const std::string& presentation_url);
- // Returns true if this object is associated with |render_frame_host|.
- bool FrameMatches(content::RenderFrameHost* render_frame_host) const;
-
+ RenderFrameHost* render_frame_host_;
PresentationServiceDelegate* delegate_;
// Map from presentation URL to its ScreenAvailabilityContext state machine.
@@ -308,16 +277,10 @@
int next_request_session_id_;
base::hash_map<int, linked_ptr<NewSessionMojoCallback>> pending_session_cbs_;
- scoped_ptr<DefaultSessionStartContext> default_session_start_context_;
-
// RAII binding of |this| to an Presentation interface request.
// The binding is removed when binding_ is cleared or goes out of scope.
scoped_ptr<mojo::Binding<presentation::PresentationService>> binding_;
- // ID of the RenderFrameHost this object is associated with.
- int render_process_id_;
- int render_frame_id_;
-
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<PresentationServiceImpl> weak_factory_;
« no previous file with comments | « no previous file | content/browser/presentation/presentation_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698