Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 1102683002: Revert of [Presentation API] Implement ondefaultsessionstart in PSImpl. (Closed)

Created:
5 years, 8 months ago by vmpstr
Modified:
5 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Presentation API] Implement ondefaultsessionstart in PSImpl. (patchset #7 id:180001 of https://codereview.chromium.org/1073893003/) Reason for revert: Speculative revert to fix content_unittests failures: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27420 Original issue's description: > [Presentation API] Implement ondefaultsessionstart in PSImpl. > > Added DefaultSessionStartContext for coordinating sending default > session back to PresentationDispatcher. > > When ListenForDefaultSessionStart is called, DefaultSessionStartContext > will be installed on PresentationServiceImpl. When both the default > session and PresentationDispatcher's callback are available, the > callback will be invoked with the session. > > On Reset(), if a callback is available, it will be invoked with null. > Changed PresentationDispatcher to not update Blink in that case. > > Also, PSImpl now keeps track of the corresponding RFH's ID instead of > RFH* since most of the time we only need to use the ID. > > Changed PresentationServiceDelegate's Add/RemoveObserver interface, > since the PresentationServiceDelegate need to be able to correlate > an Observer with a RFH. (at most 1 per RFH, as it stands today). > > Added OnDefaultPresentationStarted to > PresentationServiceDelegate::Observer interface and implemented it > in PresentationServiceImpl. > > Added tests in PresentationServiceImpl. > > BUG=459001 > > Committed: https://crrev.com/79ddfb2383dca537e481eb9e0a477267dd48bc60 > Cr-Commit-Position: refs/heads/master@{#326353} TBR=avayvod@google.com,avi@chromium.org,imcheng@chromium.org,mfoltz@chromium.org,avayvod@chromium.org,imcheng@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459001 Committed: https://crrev.com/89a5c0d4bc4e43ac69ee4db6a01916f41ccf2c0f Cr-Commit-Position: refs/heads/master@{#326378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -244 lines) Patch
M content/browser/presentation/presentation_service_impl.h View 5 chunks +1 line, -38 lines 0 comments Download
M content/browser/presentation/presentation_service_impl.cc View 13 chunks +32 lines, -84 lines 0 comments Download
M content/browser/presentation/presentation_service_impl_unittest.cc View 8 chunks +12 lines, -98 lines 0 comments Download
M content/common/presentation/presentation_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/presentation_service_delegate.h View 2 chunks +5 lines, -19 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
Created Revert of [Presentation API] Implement ondefaultsessionstart in PSImpl.
5 years, 8 months ago (2015-04-22 22:08:36 UTC) #1
imcheng
lgtm
5 years, 8 months ago (2015-04-22 22:10:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102683002/1
5 years, 8 months ago (2015-04-22 22:12:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 22:16:11 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 22:17:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89a5c0d4bc4e43ac69ee4db6a01916f41ccf2c0f
Cr-Commit-Position: refs/heads/master@{#326378}

Powered by Google App Engine
This is Rietveld 408576698