Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 1102673006: Make CL_extractCSSMKeyNSS leak suppression more specific. (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CL_extractCSSMKeyNSS leak suppression more specific. The bug is in Apple's CL_extractCSSMKeyNSS, specifically when it allocates some memory directly at the top of the function. Move it out of the Chromium bugs section and cite openradar. BUG=481286 Committed: https://crrev.com/353135db2a22f4dd5aa7fced06141c4af668893d Cr-Commit-Position: refs/heads/master@{#326977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -18 lines) Patch
M tools/valgrind/memcheck/suppressions_mac.txt View 2 chunks +8 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
This should be somewhat more targeted to the Apple bug.
5 years, 8 months ago (2015-04-25 15:44:59 UTC) #2
Jeffrey Yasskin
LGTM, thanks! And get well soon!
5 years, 8 months ago (2015-04-25 18:41:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102673006/1
5 years, 8 months ago (2015-04-25 18:42:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-25 18:52:14 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 18:53:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/353135db2a22f4dd5aa7fced06141c4af668893d
Cr-Commit-Position: refs/heads/master@{#326977}

Powered by Google App Engine
This is Rietveld 408576698