Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: ui/events/ozone/evdev/keyboard_evdev.cc

Issue 1102673002: Revert of Ozone support for device special cases in keyboard event rewriting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/ozone/evdev/keyboard_evdev.cc
diff --git a/ui/events/ozone/evdev/keyboard_evdev.cc b/ui/events/ozone/evdev/keyboard_evdev.cc
index 2c14f600aadb2d54462ecf582e06d435d802721a..1d4a5af8ac6d79411a7a1df4c9b212959e390091 100644
--- a/ui/events/ozone/evdev/keyboard_evdev.cc
+++ b/ui/events/ozone/evdev/keyboard_evdev.cc
@@ -63,7 +63,6 @@
repeat_enabled_(true),
repeat_key_(KEY_RESERVED),
repeat_sequence_(0),
- repeat_device_id_(0),
weak_ptr_factory_(this) {
repeat_delay_ = base::TimeDelta::FromMilliseconds(kRepeatDelayMs);
repeat_interval_ = base::TimeDelta::FromMilliseconds(kRepeatIntervalMs);
@@ -74,8 +73,7 @@
void KeyboardEvdev::OnKeyChange(unsigned int key,
bool down,
- base::TimeDelta timestamp,
- int device_id) {
+ base::TimeDelta timestamp) {
if (key > KEY_MAX)
return;
@@ -88,8 +86,8 @@
else
key_state_.reset(key);
- UpdateKeyRepeat(key, down, device_id);
- DispatchKey(key, down, false /* repeat */, timestamp, device_id);
+ UpdateKeyRepeat(key, down);
+ DispatchKey(key, down, false /* repeat */, timestamp);
}
void KeyboardEvdev::SetCapsLockEnabled(bool enabled) {
@@ -141,20 +139,17 @@
modifiers_->UpdateModifier(modifier, down);
}
-void KeyboardEvdev::UpdateKeyRepeat(unsigned int key,
- bool down,
- int device_id) {
+void KeyboardEvdev::UpdateKeyRepeat(unsigned int key, bool down) {
if (!repeat_enabled_)
StopKeyRepeat();
else if (key != repeat_key_ && down)
- StartKeyRepeat(key, device_id);
+ StartKeyRepeat(key);
else if (key == repeat_key_ && !down)
StopKeyRepeat();
}
-void KeyboardEvdev::StartKeyRepeat(unsigned int key, int device_id) {
+void KeyboardEvdev::StartKeyRepeat(unsigned int key) {
repeat_key_ = key;
- repeat_device_id_ = device_id;
repeat_sequence_++;
ScheduleKeyRepeat(repeat_delay_);
@@ -177,7 +172,7 @@
return;
DispatchKey(repeat_key_, true /* down */, true /* repeat */,
- EventTimeForNow(), repeat_device_id_);
+ EventTimeForNow());
ScheduleKeyRepeat(repeat_interval_);
}
@@ -185,8 +180,7 @@
void KeyboardEvdev::DispatchKey(unsigned int key,
bool down,
bool repeat,
- base::TimeDelta timestamp,
- int device_id) {
+ base::TimeDelta timestamp) {
DomCode dom_code =
KeycodeConverter::NativeKeycodeToDomCode(EvdevCodeToNativeCode(key));
// DomCode constants are not included here because of conflicts with
@@ -207,7 +201,6 @@
KeyEvent event(down ? ET_KEY_PRESSED : ET_KEY_RELEASED, key_code, dom_code,
modifiers_->GetModifierFlags(), dom_key, character, timestamp);
- event.set_source_device_id(device_id);
if (platform_keycode)
event.set_platform_keycode(platform_keycode);
callback_.Run(&event);
« no previous file with comments | « ui/events/ozone/evdev/keyboard_evdev.h ('k') | ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698