Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: ui/views/controls/menu/menu_separator_win.cc

Issue 11026076: Added MenuConfig setter to MenuItemView, updated rest of the code to use set MenuConfig if it avail… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/views/controls/menu/menu_separator_views.cc ('k') | ui/views/controls/menu/submenu_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/controls/menu/menu_separator.h" 5 #include "ui/views/controls/menu/menu_separator.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <uxtheme.h> 8 #include <uxtheme.h>
9 #include <Vssym32.h> 9 #include <Vssym32.h>
10 10
11 #include "ui/base/native_theme/native_theme.h" 11 #include "ui/base/native_theme/native_theme.h"
12 #include "ui/gfx/canvas.h" 12 #include "ui/gfx/canvas.h"
13 #include "ui/gfx/rect.h" 13 #include "ui/gfx/rect.h"
14 #include "ui/views/controls/menu/menu_config.h" 14 #include "ui/views/controls/menu/menu_config.h"
15 #include "ui/views/controls/menu/menu_item_view.h" 15 #include "ui/views/controls/menu/menu_item_view.h"
16 16
17 namespace views { 17 namespace views {
18 18
19 void MenuSeparator::OnPaint(gfx::Canvas* canvas) { 19 void MenuSeparator::OnPaint(gfx::Canvas* canvas) {
20 const MenuConfig& config = MenuConfig::instance(); 20 const MenuConfig& config = parent_menu_item_->GetMenuConfig();
21 // The gutter is rendered before the background. 21 // The gutter is rendered before the background.
22 int start_x = 0; 22 int start_x = 0;
23 const ui::NativeTheme* theme = ui::NativeTheme::instance(); 23 const ui::NativeTheme* theme = ui::NativeTheme::instance();
24 if (config.render_gutter) { 24 if (config.render_gutter) {
25 // If render_gutter is true, we're on Vista and need to render the 25 // If render_gutter is true, we're on Vista and need to render the
26 // gutter, then indent the separator from the gutter. 26 // gutter, then indent the separator from the gutter.
27 gfx::Rect gutter_bounds(MenuItemView::label_start() - 27 gfx::Rect gutter_bounds(MenuItemView::label_start() -
28 config.gutter_to_label - config.gutter_width, 0, 28 config.gutter_to_label - config.gutter_width, 0,
29 config.gutter_width, height()); 29 config.gutter_width, height());
30 ui::NativeTheme::ExtraParams extra; 30 ui::NativeTheme::ExtraParams extra;
31 theme->Paint(canvas->sk_canvas(), ui::NativeTheme::kMenuPopupGutter, 31 theme->Paint(canvas->sk_canvas(), ui::NativeTheme::kMenuPopupGutter,
32 ui::NativeTheme::kNormal, gutter_bounds, extra); 32 ui::NativeTheme::kNormal, gutter_bounds, extra);
33 start_x = gutter_bounds.x() + config.gutter_width; 33 start_x = gutter_bounds.x() + config.gutter_width;
34 } 34 }
35 35
36 gfx::Rect separator_bounds(start_x, 0, width(), height()); 36 gfx::Rect separator_bounds(start_x, 0, width(), height());
37 ui::NativeTheme::ExtraParams extra; 37 ui::NativeTheme::ExtraParams extra;
38 extra.menu_separator.has_gutter = config.render_gutter; 38 extra.menu_separator.has_gutter = config.render_gutter;
39 theme->Paint(canvas->sk_canvas(), ui::NativeTheme::kMenuPopupSeparator, 39 theme->Paint(canvas->sk_canvas(), ui::NativeTheme::kMenuPopupSeparator,
40 ui::NativeTheme::kNormal, separator_bounds, extra); 40 ui::NativeTheme::kNormal, separator_bounds, extra);
41 } 41 }
42 42
43 gfx::Size MenuSeparator::GetPreferredSize() { 43 gfx::Size MenuSeparator::GetPreferredSize() {
44 return gfx::Size(10, // Just in case we're the only item in a menu. 44 return gfx::Size(10, // Just in case we're the only item in a menu.
45 MenuConfig::instance().separator_height); 45 parent_menu_item_->GetMenuConfig().separator_height);
46 } 46 }
47 47
48 } // namespace views 48 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/controls/menu/menu_separator_views.cc ('k') | ui/views/controls/menu/submenu_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698