Chromium Code Reviews
Help | Chromium Project | Sign in
(138)

Issue 11026036: Fix lint error in parallel processing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by Torne
Modified:
2 years, 6 months ago
Reviewers:
dmazzoni
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix lint error in parallel processing. gyp.input fails the presubmit lint check because of an uninitialised global. The last rewrite of the parallel processing CL eliminated the need for this to be global, so just remove the global declaration. Committed: https://code.google.com/p/gyp/source/detail?r=1515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M pylib/gyp/input.py View 1 chunk +0 lines, -1 line 0 comments Download
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Torne
Hi Dominic, this is a fix for your parallel processing code to make it pass ...
2 years, 6 months ago (2012-10-04 11:15:14 UTC) #1
dmazzoni
2 years, 6 months ago (2012-10-04 16:50:26 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771