Adding GetFeedbackLogs call to DebugDaemon Dbus client.

Adding GetFeedbackLogs call to DebugDaemon Dbus client.


BUG=138582
TEST=None.

[rkc, 2012-10-01 20:05:31]

Thanks for working on this Constantin!

https://codereview.chromium.org/11026008/diff/1/chromeos/dbus/debug_daemon_cl...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/11026008/diff/1/chromeos/dbus/debug_daemon_cl...
chromeos/dbus/debug_daemon_client.cc:552: virtual void GetFeedbackLogs(const
GetAllLogsCallback& callback) OVERRIDE {
Need a whitespace between the end of the last method and the beginning of the
next. Needs to be fixed a lot of places.

[tudalex(Chromium), 2012-10-02 19:10:37]

https://codereview.chromium.org/11026008/diff/1/chromeos/dbus/debug_daemon_cl...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/11026008/diff/1/chromeos/dbus/debug_daemon_cl...
chromeos/dbus/debug_daemon_client.cc:552: virtual void GetFeedbackLogs(const
GetAllLogsCallback& callback) OVERRIDE {
On 2012/10/01 20:05:32, Rahul Chaturvedi wrote:
> Need a whitespace between the end of the last method and the beginning of the
> next. Needs to be fixed a lot of places.
> 
I've seen that they didn't have and I thought it was better to keep the style
:). Done.

[rkc, 2012-10-02 19:33:20]

LGTM with the one nit.

https://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon...
chromeos/dbus/debug_daemon_client.cc:560: virtual void GetFeedbackLogs(const
GetAllLogsCallback& callback) OVERRIDE {
New line above this one too.

[rkc, 2012-10-04 20:49:34]

satorux@ can do it.

On 2012/10/02 19:33:20, Rahul Chaturvedi wrote:
> LGTM with the one nit.
> 
>
https://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon...
> File chromeos/dbus/debug_daemon_client.cc (right):
> 
>
https://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon...
> chromeos/dbus/debug_daemon_client.cc:560: virtual void GetFeedbackLogs(const
> GetAllLogsCallback& callback) OVERRIDE {
> New line above this one too.

[satorux1, 2012-10-05 06:23:57]

http://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon_...
File chromeos/dbus/debug_daemon_client.cc (right):

http://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon_...
chromeos/dbus/debug_daemon_client.cc:252: "GetAllLogs");
Please define and use a constant for this.

http://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon_...
chromeos/dbus/debug_daemon_client.cc:264: "GetFeedbackLogs");
Please define and use a constant for this.

[tudalex(Chromium), 2012-10-31 10:53:16]

https://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon...
File chromeos/dbus/debug_daemon_client.cc (right):

https://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon...
chromeos/dbus/debug_daemon_client.cc:252: "GetAllLogs");
On 2012/10/05 06:23:57, satorux1 wrote:
> Please define and use a constant for this.

Done.

https://codereview.chromium.org/11026008/diff/4001/chromeos/dbus/debug_daemon...
chromeos/dbus/debug_daemon_client.cc:264: "GetFeedbackLogs");
On 2012/10/05 06:23:57, satorux1 wrote:
> Please define and use a constant for this.

Done.

[satorux1, 2012-11-01 01:59:10]

LGTM with a nit

http://codereview.chromium.org/11026008/diff/9001/chromeos/dbus/debug_daemon_...
File chromeos/dbus/debug_daemon_client.cc (right):

http://codereview.chromium.org/11026008/diff/9001/chromeos/dbus/debug_daemon_...
chromeos/dbus/debug_daemon_client.cc:562: }
nit: put a blank line here