Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1102573006: Update {virtual,override} to follow C++11 style in media. (Closed)

Created:
5 years, 8 months ago by ncarter (slow)
Modified:
5 years, 8 months ago
Reviewers:
wolenetz
CC:
chromium-reviews, posciak+watch_chromium.org, yusukes+watch_chromium.org, eme-reviews_chromium.org, binji+watch_chromium.org, tzik, mcasas+watch_chromium.org, raymes+watch_chromium.org, feature-media-reviews_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override} to follow C++11 style in media. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was manually generated using a regex and a text editor. BUG=417463 Committed: https://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b Cr-Commit-Position: refs/heads/master@{#326862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -129 lines) Patch
M media/audio/agc_audio_stream.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/alsa/alsa_output_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/cras/cras_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/cras/cras_unified_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/openbsd/audio_manager_openbsd.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/audio/win/audio_low_latency_input_win_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M media/base/fake_audio_render_callback.h View 1 chunk +4 lines, -5 lines 0 comments Download
M media/base/fake_text_track_stream.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/base/mock_audio_renderer_sink.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cdm/ppapi/cdm_file_io_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/cdm/ppapi/cdm_file_io_test.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cdm/ppapi/cdm_helpers.h View 5 chunks +33 lines, -30 lines 0 comments Download
M media/cdm/ppapi/cdm_wrapper.h View 4 chunks +24 lines, -24 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/fake_cdm_video_decoder.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/ffmpeg_cdm_video_decoder.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/libvpx_cdm_video_decoder.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/renderers/mock_gpu_video_accelerator_factories.h View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ncarter (slow)
wolentez: please review! thanks.
5 years, 8 months ago (2015-04-23 02:57:54 UTC) #2
ncarter (slow)
matt: ping :)
5 years, 8 months ago (2015-04-24 16:15:09 UTC) #3
wolenetz
On 2015/04/24 16:15:09, ncarter wrote: > matt: ping :) On it now. I was TMCTWD'ing ...
5 years, 8 months ago (2015-04-24 18:16:54 UTC) #4
wolenetz
lgtm
5 years, 8 months ago (2015-04-24 18:30:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102573006/1
5 years, 8 months ago (2015-04-24 19:11:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 20:13:39 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 20:14:32 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3915ed9aeda4c38a8d391f7f41f127a790a762b
Cr-Commit-Position: refs/heads/master@{#326862}

Powered by Google App Engine
This is Rietveld 408576698