Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1102543003: Revert of Reland: Introduce sys_sigprocmask and sys_sigaction. (Closed)

Created:
5 years, 8 months ago by magjed_chromium
Modified:
5 years, 8 months ago
Reviewers:
hidehiko, mdempsky
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org, Mark Seaborn, hamaji, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #5 id:160001 of https://codereview.c… (patchset #4 id:80001 of https://codereview.chromium.org/1092153005/) Reason for revert: Causing Linux Tests to fail: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/41533 sandbox_linux_unittests Trap.SigSysAction failed 14 failures: Syscall.SyntheticSixArgs SandboxBPF.PthreadEquality SandboxBPF.Pread64 SandboxBPF.UnsafeTrapWithErrno SandboxBPF.ForwardSyscall SandboxBPF.BasicBlacklistWithSigsys SandboxBPF.SigBus Trap.SigSysAction SandboxBPF.VerboseAPITesting ParameterRestrictions.sched_getparam_allowed SandboxBPF.UnsafeTrapWithCond [ RUN ] SandboxBPF.VerboseAPITesting ../../sandbox/linux/tests/unit_tests.cc:234: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Original issue's description: > Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #5 id:160001 of https://codereview.chromium.org/1077143002/) > > This CL is relanding the CL https://codereview.chromium.org/1077143002/, > which was reverted due to false alarm of the memory sanitizer. > Because the memory sanitizer does not know about direct kernel syscall > does, so it warns the arguments of the signal handler, unexpectedly. > This CL adds the msan unpoisoning to the arguemtns, so that the memory > sanitizer should understand it. > > TEST=Ran sandbox_linux_unittests with msan=1. Ran bots. > BUG=358465 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_trusty32_rel,linux_arm > > Committed: https://crrev.com/c1c944e1ee0b100c9717084b50bdd697c6b308d2 > Cr-Commit-Position: refs/heads/master@{#326270} TBR=mdempsky@chromium.org,hidehiko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=358465, 479705 Committed: https://crrev.com/958459af4fb9f922a22ab0d1fc32145f237793d4 Cr-Commit-Position: refs/heads/master@{#326278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -593 lines) Patch
M sandbox/linux/BUILD.gn View 1 chunk +4 lines, -5 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 chunk +5 lines, -5 lines 0 comments Download
M sandbox/linux/sandbox_linux_test_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/die.cc View 2 chunks +1 line, -6 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.h View 1 chunk +5 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 7 chunks +17 lines, -25 lines 0 comments Download
D sandbox/linux/seccomp-bpf/trap_unittest.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M sandbox/linux/services/credentials.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.h View 2 chunks +0 lines, -12 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers.cc View 2 chunks +0 lines, -61 lines 0 comments Download
M sandbox/linux/services/syscall_wrappers_unittest.cc View 2 chunks +0 lines, -14 lines 0 comments Download
A sandbox/linux/system_headers/android_arm64_ucontext.h View 1 chunk +29 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_arm_ucontext.h View 1 chunk +32 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_i386_ucontext.h View 1 chunk +79 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_mips_ucontext.h View 1 chunk +51 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_ucontext.h View 1 chunk +28 lines, -0 lines 0 comments Download
A sandbox/linux/system_headers/android_x86_64_ucontext.h View 1 chunk +88 lines, -0 lines 0 comments Download
D sandbox/linux/system_headers/arm64_linux_ucontext.h View 1 chunk +0 lines, -29 lines 0 comments Download
D sandbox/linux/system_headers/arm_linux_ucontext.h View 1 chunk +0 lines, -67 lines 0 comments Download
D sandbox/linux/system_headers/i386_linux_ucontext.h View 1 chunk +0 lines, -93 lines 0 comments Download
D sandbox/linux/system_headers/linux_signal.h View 1 chunk +0 lines, -73 lines 0 comments Download
D sandbox/linux/system_headers/linux_ucontext.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sandbox/linux/system_headers/mips_linux_ucontext.h View 1 chunk +0 lines, -51 lines 0 comments Download
D sandbox/linux/system_headers/x86_64_linux_ucontext.h View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
magjed_chromium
Created Revert of Reland: Introduce sys_sigprocmask and sys_sigaction. (patchset #5 id:160001 of https://codereview.c…
5 years, 8 months ago (2015-04-22 13:00:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102543003/1
5 years, 8 months ago (2015-04-22 13:03:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 13:04:05 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/958459af4fb9f922a22ab0d1fc32145f237793d4 Cr-Commit-Position: refs/heads/master@{#326278}
5 years, 8 months ago (2015-04-22 13:04:55 UTC) #5
mdempsky
5 years, 8 months ago (2015-04-22 19:55:29 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698