Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1102513002: convert gin to use phantom weak callbacks (Closed)

Created:
5 years, 8 months ago by dcarney
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert gin to use phantom weak callbacks the old style callbacks are going away BUG= Committed: https://crrev.com/99ade908da2443a531001afafea4a72fb7e755bc Cr-Commit-Position: refs/heads/master@{#326259}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
M gin/array_buffer.cc View 1 2 chunks +14 lines, -7 lines 0 comments Download
M gin/function_template.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M gin/function_template.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M gin/wrappable.h View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M gin/wrappable.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-22 08:16:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102513002/40001
5 years, 8 months ago (2015-04-22 08:17:06 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-22 09:55:53 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 09:56:46 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/99ade908da2443a531001afafea4a72fb7e755bc
Cr-Commit-Position: refs/heads/master@{#326259}

Powered by Google App Engine
This is Rietveld 408576698