Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1102463002: Add a MockAsyncProxyResolverFactory and update some tests to use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@proxy-factory-refactor
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index eb811613557b1c30c9a45a1e1ba783022510fa5b..54768c70723c6039df2cea2678cee1852e5d2ce1 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -9509,6 +9509,24 @@ class CapturingProxyResolver : public ProxyResolver {
DISALLOW_COPY_AND_ASSIGN(CapturingProxyResolver);
};
+class CapturingProxyResolverFactory : public ProxyResolverFactory {
+ public:
+ CapturingProxyResolverFactory(CapturingProxyResolver* resolver)
+ : ProxyResolverFactory(false), resolver_(resolver) {}
+
+ int CreateProxyResolver(
+ const scoped_refptr<ProxyResolverScriptData>& pac_script,
+ scoped_ptr<ProxyResolver>* resolver,
+ const net::CompletionCallback& callback,
+ scoped_ptr<Request>* request) override {
+ resolver->reset(new ForwardingProxyResolver(resolver_));
+ return OK;
+ }
+
+ private:
+ ProxyResolver* resolver_;
+};
+
TEST_P(HttpNetworkTransactionTest,
UseAlternateProtocolForTunneledNpnSpdy) {
session_deps_.use_alternate_protocols = true;
@@ -9522,7 +9540,7 @@ TEST_P(HttpNetworkTransactionTest,
session_deps_.proxy_service.reset(new ProxyService(
new ProxyConfigServiceFixed(proxy_config),
make_scoped_ptr(
- new ForwardingProxyResolverFactory(&capturing_proxy_resolver)),
+ new CapturingProxyResolverFactory(&capturing_proxy_resolver)),
NULL));
TestNetLog net_log;
session_deps_.net_log = &net_log;

Powered by Google App Engine
This is Rietveld 408576698