Issue 11024005: Revert merges of r12531 and r12562 from 3.12 branch, going back to 3.12.19.12

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11024005: Revert merges of r12531 and r12562 from 3.12 branch, going back to 3.12.19.12 (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow

Modified:
8 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.12

Visibility:
Public.

More Reviews

Description

Revert merges of r12531 and r12562 from 3.12 branch, going back to 3.12.19.12 Fix casting error for receiver of interceptors. Fix LBoundsCheck on x64 to handle (stack slot + constant) correctly. BUG=chromium:149912, 150729 Committed: https://code.google.com/p/v8/source/detail?r=12638

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed version.cc #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -68 lines)			Patch
M	src/objects.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+8 lines, -6 lines	0 comments	Download
M	src/version.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View		1 chunk	+3 lines, -9 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	test/mjsunit/regress/regress-crbug-150729.js	View		1 chunk	+0 lines, -39 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

https://codereview.chromium.org/11024005/diff/1/src/version.cc File src/version.cc (right): https://codereview.chromium.org/11024005/diff/1/src/version.cc#newcode38 src/version.cc:38: #define PATCH_LEVEL 12 We want this to be patch ...

8 years, 2 months ago (2012-10-01 11:42:40 UTC) #2

Michael Starzinger

8 years, 2 months ago (2012-10-01 11:44:02 UTC) #3

LGTM (reviewed version.cc, rubber-stamped the rest).

Expand Messages | Collapse Messages