Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 11024005: Revert merges of r12531 and r12562 from 3.12 branch, going back to 3.12.19.12 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by Jakob
Modified:
2 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Revert merges of r12531 and r12562 from 3.12 branch, going back to 3.12.19.12 Fix casting error for receiver of interceptors. Fix LBoundsCheck on x64 to handle (stack slot + constant) correctly. BUG=chromium:149912, 150729 Committed: https://code.google.com/p/v8/source/detail?r=12638

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed version.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -68 lines) Patch
M src/objects.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M src/version.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -10 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-150729.js View 1 chunk +0 lines, -39 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Jakob
$ git diff svn/tags/3.12.19.12 | wc -l 0
2 years, 5 months ago (2012-10-01 11:41:22 UTC) #1
Michael Starzinger
https://codereview.chromium.org/11024005/diff/1/src/version.cc File src/version.cc (right): https://codereview.chromium.org/11024005/diff/1/src/version.cc#newcode38 src/version.cc:38: #define PATCH_LEVEL 12 We want this to be patch ...
2 years, 5 months ago (2012-10-01 11:42:40 UTC) #2
Michael Starzinger
2 years, 5 months ago (2012-10-01 11:44:02 UTC) #3
LGTM (reviewed version.cc, rubber-stamped the rest).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted