Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1102383002: Revert of Preprocess structured stack trace on GC to get rid of code reference. (Closed)

Created:
5 years, 7 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 7 months ago
CC:
v8-dev, alph
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Preprocess structured stack trace on GC to get rid of code reference. (patchset #5 id:80001 of https://codereview.chromium.org/1103843002/) Reason for revert: Broke GCStress Original issue's description: > Preprocess structured stack trace on GC to get rid of code reference. > > R=verwaest@chromium.org > BUG=v8:2340 > LOG=N > > Committed: https://crrev.com/462ffa1dfa0ab3a851ea0294470d1ed7ed12dd56 > Cr-Commit-Position: refs/heads/master@{#28085} TBR=verwaest@chromium.org,ulan@chromium.org,hpayer@chromium.org,yurys@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:2340 Committed: https://crrev.com/919c54910f70696d9cef5fd0f6e50be8205ae4d0 Cr-Commit-Position: refs/heads/master@{#28086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -76 lines) Patch
M src/factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/heap.h View 2 chunks +1 line, -4 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +0 lines, -25 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Lomov (no reviews)
Created Revert of Preprocess structured stack trace on GC to get rid of code reference.
5 years, 7 months ago (2015-04-27 15:53:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102383002/1
5 years, 7 months ago (2015-04-27 15:53:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-27 15:53:51 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/919c54910f70696d9cef5fd0f6e50be8205ae4d0 Cr-Commit-Position: refs/heads/master@{#28086}
5 years, 7 months ago (2015-04-27 15:54:03 UTC) #4
Yang
5 years, 7 months ago (2015-04-27 16:06:30 UTC) #5
Message was sent while issue was closed.
On 2015/04/27 15:54:03, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/919c54910f70696d9cef5fd0f6e50be8205ae4d0
> Cr-Commit-Position: refs/heads/master@{#28086}

Thank you for the revert.

Powered by Google App Engine
This is Rietveld 408576698