LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html - Issue 1102363002: Add Client Attribute to FetchEvent- Blink Side.

Unified Diff: LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html

Issue 1102363002: Add Client Attribute to FetchEvent- Blink Side. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/resources/fetch-event-client-attribute-test-worker.js » ('j') | LayoutTests/http/tests/serviceworker/resources/fetch-event-client-attribute-test-worker.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html

diff --git a/LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html b/LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html

new file mode 100644

index 0000000000000000000000000000000000000000..e3a32413a7c233b4487698222353f18a50ce64a4

--- /dev/null

+++ b/LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html

@@ -0,0 +1,27 @@

+<!DOCTYPE html>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

+<script src="resources/test-helpers.js"></script>

+<body>

+<script>

+var worker = 'resources/fetch-event-client-attribute-test-worker.js';

+var scope = 'resources/simple.html';

+promise_test(function(test) {

+ return service_worker_unregister_and_register(test, worker, scope)

+ .then(function(registration) {

+ return wait_for_state(test, registration.installing, 'activated');

+ })

+ .then(function() { return with_iframe(scope); })

+ .then(function(frame) {

+ assert_equals(frame.contentDocument.body.textContent, "top-level", "frameType should be top-level");

jsbell 2015/05/06 16:21:26 Interesting... given the table in fetch.spec.whatw

jsbell 2015/05/06 16:21:26 Please wrap to 80 columns (e.g. break after the "t

falken 2015/05/07 04:06:03 Can you file a bug if it's an existing bug?

Paritosh Kumar 2015/05/07 16:46:54 I'm not updating on this now, first we will have t

falken 2015/05/08 22:20:25 Can you elaborate on this? It looks like you're te

Paritosh Kumar 2015/05/12 11:52:28 I investigated this issue and found that, this is

+ frame.remove();

+ add_completion_callback(function() {

falken 2015/05/07 04:06:03 I don't think you need this since you call service

Paritosh Kumar 2015/05/07 16:46:54 Yes, Not Required. Thanks.

+ registration.unregister();

+ });

+ return service_worker_unregister_and_done(test, scope);

+ });

+ }, 'Service Worker responds to fetch event with client frameType');

falken 2015/05/07 04:06:03 this indentation is 2 spaces too many

Paritosh Kumar 2015/05/07 16:46:54 Done.

+</script>

+</body>