LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html - Issue 1102363002: Add Client Attribute to FetchEvent- Blink Side.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/fetch-event-client-attribute.html

Issue 1102363002: Add Client Attribute to FetchEvent- Blink Side. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/resources/fetch-event-client-attribute-test-worker.js » ('j') | LayoutTests/http/tests/serviceworker/resources/fetch-event-client-attribute-test-worker.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script src="resources/test-helpers.js"></script>

	5 <body>

	6 <script>

	7 var worker = 'resources/fetch-event-client-attribute-test-worker.js';

	8

	9 function test() {
	jsbell 2015/05/05 17:45:42 Please do not override the `test` function provide Please do not override the `test` function provided by testharness.js Paritosh Kumar 2015/05/06 11:42:36 Ohh sorry for noise, this was useless method. Show quoted text On 2015/05/05 17:45:42, jsbell wrote: > Please do not override the `test` function provided by testharness.js Ohh sorry for noise, this was useless method.
	10 window.onmessage = function(e) {assert_equals(e.data.actual, e.data.expected) }

	11 }

	12

	13 async_test(function(t) {
	jsbell 2015/05/05 17:45:42 You should be able to use service_worker_test() to You should be able to use service_worker_test() to simplify this dramatically. See skip-waiting-without-client.html and resources/skip-waiting-worker.js for an example. If that is insufficient (due to not having an appropriate fetch) then please at least use promise_test. Paritosh Kumar 2015/05/06 11:42:36 Using primise_test, as do not have an appropriate Using primise_test, as do not have an appropriate fetch.
	14 var scope = 'resources/simple.html';

	15 service_worker_unregister_and_register(t, worker, scope)

	16 .then(function(reg) {

	17 return wait_for_state(t, reg.installing, 'activated');

	18 })

	19 .then(function() { return with_iframe(scope); })

	20 .then(function(frame) {

	21

	22 assert_equals(frame.contentDocument.body.textContent, "top-level", "fr ameType should be Top-Level");

	23 frame.remove();

	24 return service_worker_unregister_and_done(t, scope);

	25 })

	26 .catch(unreached_rejection(t));

	27 }, 'Service Worker responds to fetch event with client frameType');

	28

	29 </script>

	30 </body>

OLD	NEW