Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1102353003: [chrome/browser/notifications] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org, extensions-reviews_chromium.org, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/notifications BUG=466848 Committed: https://crrev.com/3c2aed287221bf97d294cc9cd1996e8b8cf6573d Cr-Commit-Position: refs/heads/master@{#327477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/notifications/desktop_notification_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notification_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-04-29 07:01:56 UTC) #2
Peter Beverloo
lgtm
5 years, 7 months ago (2015-04-29 11:12:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102353003/1
5 years, 7 months ago (2015-04-29 11:12:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102353003/1
5 years, 7 months ago (2015-04-29 12:24:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 12:25:01 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 12:26:03 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3c2aed287221bf97d294cc9cd1996e8b8cf6573d
Cr-Commit-Position: refs/heads/master@{#327477}

Powered by Google App Engine
This is Rietveld 408576698