Disable ThreadWatcher in CANARY and UNKNOWN channels temporarily to measure its

Disable ThreadWatcher in CANARY and UNKNOWN channels
temporarily to measure its impact on battery.

Will be measuring its impact in the following dashboard.

https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-mac9&tests=power.top_25%2Fidle_wakeups_total&checked=idle_wakeups_total%2Cref

R=asvitkine@chromium.org
BUG=426203
Committed: https://crrev.com/4e8cfe4049b77cd552ff42e2906e85c1fd4529a3
Cr-Commit-Position: refs/heads/master@{#327354}

[Andre, 2015-04-28 02:05:21]

andresantoso@chromium.org changed reviewers:
+ andresantoso@chromium.org

[Andre, 2015-04-28 02:05:21]

I would like to see how this change affects the perf dashboards,
does it run Canary or Chromium builds?

[ramant (doing other things), 2015-04-28 02:14:56]

On 2015/04/28 02:05:21, Andre wrote:
> I would like to see how this change affects the perf dashboards,
> does it run Canary or Chromium builds?

Once this is committed, it will run in Canary or any build whose channel is
UNKNOWN.

[Alexei Svitkine (slow), 2015-04-28 14:39:00]

Why not do it as an experiment, so you can easily see the UMA data with
this on vs. off for the same days? Or are you planning to evaluate the
results with something else than UMA?

On Mon, Apr 27, 2015 at 10:14 PM, <rtenneti@chromium.org> wrote:

> On 2015/04/28 02:05:21, Andre wrote:
>
>> I would like to see how this change affects the perf dashboards,
>> does it run Canary or Chromium builds?
>>
>
> Once this is committed, it will run in Canary or any build whose channel is
> UNKNOWN.
>
> https://codereview.chromium.org/1102333004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Andre, 2015-04-28 15:54:39]

On 2015/04/28 14:39:00, Alexei Svitkine wrote:
> Why not do it as an experiment, so you can easily see the UMA data with
> this on vs. off for the same days? Or are you planning to evaluate the
> results with something else than UMA?
> 
> On Mon, Apr 27, 2015 at 10:14 PM, <mailto:rtenneti@chromium.org> wrote:
> 
> > On 2015/04/28 02:05:21, Andre wrote:
> >
> >> I would like to see how this change affects the perf dashboards,
> >> does it run Canary or Chromium builds?
> >>
> >
> > Once this is committed, it will run in Canary or any build whose channel is
> > UNKNOWN.
> >
> > https://codereview.chromium.org/1102333004/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I would like to see how much this contributes to idle wakeup numbers on the
perf dashboard. 
https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-...

[Alexei Svitkine (slow), 2015-04-28 16:38:39]

lgtm, can you add the bit about the specific perf tests you're planning to look
at in the CL description?

https://codereview.chromium.org/1102333004/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/thread_watcher.cc (right):

https://codereview.chromium.org/1102333004/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/thread_watcher.cc:542: channel ==
chrome::VersionInfo::CHANNEL_UNKNOWN)
Nit: {}'s

[ramant (doing other things), 2015-04-28 17:06:36]

Added the perf dashboard to the description.

It is great idea if we could have something like Finch trial for the perf
dashboard to measure the impact of a single change.

https://codereview.chromium.org/1102333004/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/thread_watcher.cc (right):

https://codereview.chromium.org/1102333004/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/thread_watcher.cc:542: channel ==
chrome::VersionInfo::CHANNEL_UNKNOWN)
On 2015/04/28 16:38:38, Alexei Svitkine wrote:
> Nit: {}'s

Done.

[ramant (doing other things), 2015-04-28 17:06:39]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2015-04-28 17:06:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1102333004/#ps40001
(title: "fixed nits")

[commit-bot: I haz the power, 2015-04-28 17:06:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102333004/40001

[Alexei Svitkine (slow), 2015-04-28 17:08:18]

In fact we're working on better integrating experiments and the perf
dashboards. Stay tuned!

On Tue, Apr 28, 2015 at 1:06 PM, <rtenneti@chromium.org> wrote:

> Added the perf dashboard to the description.
>
> It is great idea if we could have something like Finch trial for the perf
> dashboard to measure the impact of a single change.
>
>
>
>
https://codereview.chromium.org/1102333004/diff/20001/chrome/browser/metrics/...
> File chrome/browser/metrics/thread_watcher.cc (right):
>
>
>
https://codereview.chromium.org/1102333004/diff/20001/chrome/browser/metrics/...
> chrome/browser/metrics/thread_watcher.cc:542: channel ==
> chrome::VersionInfo::CHANNEL_UNKNOWN)
> On 2015/04/28 16:38:38, Alexei Svitkine wrote:
>
>> Nit: {}'s
>>
>
> Done.
>
> https://codereview.chromium.org/1102333004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-04-28 17:50:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-28 17:50:43]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ramant (doing other things), 2015-04-28 18:48:05]

The CQ bit was checked by rtenneti@chromium.org

[ramant (doing other things), 2015-04-28 18:48:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1102333004/#ps60001
(title: "create ThreadWatcherList for unit tests to pass")

[commit-bot: I haz the power, 2015-04-28 18:50:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1102333004/60001

[commit-bot: I haz the power, 2015-04-28 20:10:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-28 20:11:22]

Patchset 4 (id:??) landed as
https://crrev.com/4e8cfe4049b77cd552ff42e2906e85c1fd4529a3
Cr-Commit-Position: refs/heads/master@{#327354}