Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1102333002: cc: Drop skip_shared_out_of_order_tiles field from TilingSetEvictionQueue. (Closed)

Created:
5 years, 8 months ago by USE eero AT chromium.org
Modified:
5 years, 7 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Drop skip_shared_out_of_order_tiles field from TilingSetEvictionQueue. As tiles are no longer shared between active and pending trees, there are not shared tiles which could appear out of order thus the skip_shared_out_of_order_tiles field has become useless. It can thus be dropped. Committed: https://crrev.com/6da595dec4925081bda50253d57f3a4a7df157bd Cr-Commit-Position: refs/heads/master@{#328302}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -70 lines) Patch
M cc/layers/picture_layer_impl_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 4 chunks +12 lines, -13 lines 0 comments Download
M cc/resources/eviction_tile_priority_queue.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M cc/resources/tiling_set_eviction_queue.h View 9 chunks +4 lines, -13 lines 0 comments Download
M cc/resources/tiling_set_eviction_queue.cc View 1 2 8 chunks +13 lines, -37 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
USE eero AT chromium.org
PTAL.
5 years, 8 months ago (2015-04-27 13:37:53 UTC) #2
vmpstr
On 2015/04/27 13:37:53, e_hakkinen wrote: > PTAL. Thanks for doing this. This looks good, but ...
5 years, 8 months ago (2015-04-27 17:09:37 UTC) #3
vmpstr
lgtm
5 years, 7 months ago (2015-05-04 17:35:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102333002/20001
5 years, 7 months ago (2015-05-05 07:54:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/21513) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-05 07:57:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102333002/40001
5 years, 7 months ago (2015-05-05 08:19:36 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-05 09:36:50 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 09:37:51 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6da595dec4925081bda50253d57f3a4a7df157bd
Cr-Commit-Position: refs/heads/master@{#328302}

Powered by Google App Engine
This is Rietveld 408576698