Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1102313002: bindings: Move named/indexed attributes to prototype chains. (Closed)

Created:
5 years, 8 months ago by Yuki
Modified:
5 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, vivekg, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-bindings_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Move named/indexed attributes to prototype chains. The previous CL (http://crrev.com/1062713003) was reverted because of failures of browser_tests. I've fixed the issue at http://crrev.com/1061263004 , so this time should be okay ... I believe. BUG=43394, 470671 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194600

Patch Set 1 : Patched from the reverted CL: http://crrev.com/1062713003 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1418 lines, -1093 lines) Patch
M LayoutTests/fast/svg/svglist.html View 2 chunks +106 lines, -106 lines 0 comments Download
D LayoutTests/fast/svg/svglist-expected.txt View 1 chunk +0 lines, -33 lines 0 comments Download
M LayoutTests/inspector/console/console-command-copy-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/inspector/console/console-format-collections-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 28 chunks +82 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 32 chunks +99 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -7 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 45 chunks +153 lines, -128 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 211 chunks +914 lines, -770 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 14 chunks +54 lines, -43 lines 0 comments Download
M Source/core/html/HTMLAppletElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLEmbedElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Yuki
Could you review this CL? The failures of browser_tests should have been fixed by http://crrev.com/1061263004 ...
5 years, 7 months ago (2015-04-28 10:15:24 UTC) #3
haraken
LGTM!
5 years, 7 months ago (2015-04-28 10:19:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1102313002/40001
5 years, 7 months ago (2015-04-28 12:30:53 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 13:39:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194600

Powered by Google App Engine
This is Rietveld 408576698