Issue 11023010: Revert r12625 due to sandbox incompatibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11023010: Revert r12625 due to sandbox incompatibility. (Closed)

Created:
8 years, 2 months ago by Michael Starzinger

Modified:
8 years, 2 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert r12625 due to sandbox incompatibility. Original message: Implement committed physical memory stats for Linux. This had to be reverted because it crashes when compiled into Chromium due to the sandbox not allowing the mincore call. R=verwaest@chromium.org BUG=v8:2191 Committed: https://code.google.com/p/v8/source/detail?r=12640

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -159 lines)			Patch
M	include/v8.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	src/api.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download
M	src/platform.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/platform-cygwin.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/platform-freebsd.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/platform-linux.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	src/platform-macos.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/platform-nullos.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/platform-openbsd.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/platform-solaris.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/spaces.h	View	5 chunks	+0 lines, -15 lines	0 comments	Download
M	src/spaces.cc	View	4 chunks	+0 lines, -44 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages