Chromium Code Reviews
Help | Chromium Project | Sign in
(120)

Issue 11023010: Revert r12625 due to sandbox incompatibility. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Michael Starzinger
Modified:
1 year, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Revert r12625 due to sandbox incompatibility.

Original message: Implement committed physical memory stats for Linux.
This had to be reverted because it crashes when compiled into Chromium
due to the sandbox not allowing the mincore call.

R=verwaest@chromium.org
BUG=v8:2191
Committed: https://code.google.com/p/v8/source/detail?r=12640

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -159 lines) Lint Patch
M include/v8.h View 2 chunks +0 lines, -5 lines 0 comments 0 errors Download
M src/api.cc View 3 chunks +0 lines, -3 lines 0 comments 0 errors Download
M src/heap.h View 1 chunk +0 lines, -3 lines 0 comments 0 errors Download
M src/heap.cc View 1 chunk +0 lines, -14 lines 0 comments 0 errors Download
M src/platform.h View 1 chunk +0 lines, -8 lines 0 comments 0 errors Download
M src/platform-cygwin.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
M src/platform-freebsd.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
M src/platform-linux.cc View 1 chunk +0 lines, -18 lines 0 comments 0 errors Download
M src/platform-macos.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
M src/platform-nullos.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
M src/platform-openbsd.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
M src/platform-solaris.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
M src/platform-win32.cc View 1 chunk +0 lines, -7 lines 0 comments 0 errors Download
M src/spaces.h View 5 chunks +0 lines, -15 lines 0 comments 0 errors Download
M src/spaces.cc View 4 chunks +0 lines, -44 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Michael Starzinger
1 year, 6 months ago #1
Toon Verwaest
1 year, 6 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6