Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Unified Diff: content/browser/dom_storage/dom_storage_area.cc

Issue 1102263003: Discard uncommitted changes when shutting down DOMStorageArea Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/dom_storage/dom_storage_area_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/dom_storage/dom_storage_area.cc
diff --git a/content/browser/dom_storage/dom_storage_area.cc b/content/browser/dom_storage/dom_storage_area.cc
index 56a1fd008a65538bc45e707c59f530d66ab24837..bfb9434c795b09c1fb342ae1fd5ecdca1363409e 100644
--- a/content/browser/dom_storage/dom_storage_area.cc
+++ b/content/browser/dom_storage/dom_storage_area.cc
@@ -460,13 +460,7 @@ void DOMStorageArea::ShutdownInCommitSequence() {
// This method executes on the commit sequence.
DCHECK(task_runner_->IsRunningOnCommitSequence());
DCHECK(backing_.get());
- if (commit_batch_) {
- // Commit any changes that accrued prior to the timer firing.
- bool success = backing_->CommitChanges(
- commit_batch_->clear_all_first,
- commit_batch_->changed_values);
- DCHECK(success);
- }
+ // Discard any changes that accrued prior to the timer firing.
commit_batch_.reset();
backing_.reset();
session_storage_backing_ = NULL;
« no previous file with comments | « no previous file | content/browser/dom_storage/dom_storage_area_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698